Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 1292693004: [Password Manager] Autofill forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Vadym's inputs. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_form_conversion_utils.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc
index be3648b3ba9a8e1db1ed57486e5a66b76a066277..3a89823795316bd9e39f8eb6501d081623d04ef0 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc
@@ -138,15 +138,6 @@ void PopulateSyntheticFormFromWebForm(const WebFormElement& web_form,
synthetic_form->document = web_form.document();
}
-// Checks in a case-insensitive way if the autocomplete attribute for the given
-// |element| is present and has the specified |value_in_lowercase|.
-bool HasAutocompleteAttributeValue(const WebInputElement& element,
- const char* value_in_lowercase) {
- return base::LowerCaseEqualsASCII(
- base::StringPiece16(element.getAttribute("autocomplete")),
- value_in_lowercase);
-}
-
// Helper to determine which password is the main (current) one, and which is
// the new password (e.g., on a sign-up or change password form), if any.
bool LocateSpecificPasswords(std::vector<WebInputElement> passwords,
@@ -665,4 +656,11 @@ scoped_ptr<PasswordForm> CreatePasswordFormFromUnownedInputElements(
return password_form.Pass();
}
+bool HasAutocompleteAttributeValue(const blink::WebInputElement& element,
+ const char* value_in_lowercase) {
+ return base::LowerCaseEqualsASCII(
+ base::StringPiece16(element.getAttribute("autocomplete")),
+ value_in_lowercase);
+}
+
} // namespace autofill
« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698