Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: chrome/test/data/password/ambiguous_password_form.html

Issue 1292693004: [Password Manager] Autofill forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Vadym's inputs. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/password/ambiguous_password_form.html
diff --git a/chrome/test/data/password/ambiguous_password_form.html b/chrome/test/data/password/ambiguous_password_form.html
new file mode 100644
index 0000000000000000000000000000000000000000..e2802f9d5c5ba677bc7b0f12654e13c12533859a
--- /dev/null
+++ b/chrome/test/data/password/ambiguous_password_form.html
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<!-- Password form with the username and password fields having ambiguity in id attribute. -->
+<form id='ambiguous_form' method='POST' action='done.html'>
+ <label>Username: </label><input type='text' id='ambiguous_id' />
+ <label>Password: </label><input type='password' id='ambiguous_id' />
+ <input type='submit' />
+</form>
+
+<!-- Password form having username and password fields without name and id attribute. -->
+<form id='no_name_id_form' method='POST' action='done.html'>
+ <label>Username: </label> <input type='text' placeholder='username' />
+ <label>Password: </label> <input type='password' placeholder='password' />
+ <input type='submit' />
+</form>
+
+<!-- Change password form having username and password fields with empty names along with |autocomplete='xxx'| attributes. -->
+<form id='change_pwd' method='POST' action='done.html'>
+ <label>Username: </label> <input type='text' placeholder='username' />
+ <label>Old Password: </label> <input type='password' placeholder='Old Password' autocomplete='current-password' />
+ <label>New Password: </label> <input type='password' placeholder='New password' autocomplete='new-password' />
+ <input type='submit' />
+</form>
+
+<!-- Change password form having username and password fields with empty names along with |autocomplete='new-password'| attributes. -->
+<form id='change_pwd_but_no_old_pwd' method='POST' action='done.html'>
+ <label>Username: </label> <input type='text' placeholder='username' />
+ <label>New Password: </label> <input type='password' placeholder='New Password' autocomplete='new-password' />
+ <label>Confirm Password: </label> <input type='password' placeholder='Retype password' autocomplete='new-password' />
+ <input type='submit' />
+</form>
+
+<!-- Change password form having username and password fields with empty names but no |autocomplete='xxx'| attributes. -->
+<form id='change_pwd_but_no_autocomplete' method='POST' action='done.html'>
+ <label>Username: </label> <input type='text' placeholder='username' />
+ <label>Old Password: </label> <input type='password' placeholder='Old Password' />
+ <label>New Password: </label> <input type='password' placeholder='New password' />
+ <input type='submit' />
+</form>

Powered by Google App Engine
This is Rietveld 408576698