chrome/test/data/password/ambiguous_password_form.html - Issue 1292693004: [Password Manager] Autofill forms with field name and id attributes missing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/password/ambiguous_password_form.html

Issue 1292693004: [Password Manager] Autofill forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Vadym's inputs. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/autofill/content/renderer/password_autofill_agent.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/password/ambiguous_password_form.html

diff --git a/chrome/test/data/password/ambiguous_password_form.html b/chrome/test/data/password/ambiguous_password_form.html

new file mode 100644

index 0000000000000000000000000000000000000000..5eac2be6e94e074da31b86f0f105c4eec11205ea

--- /dev/null

+++ b/chrome/test/data/password/ambiguous_password_form.html

@@ -0,0 +1,14 @@

+<!DOCTYPE html>

+

+ <form id="ambiguous_form" method="POST" action="done.html">

+ <label>Username: </label><input type="text" id="ambiguous_id" />

+ <label>Password: </label><input type="password" id="ambiguous_id"/>

+ <input type="submit" />

+</form>

+

+ <form id="no_username_id_form" method="POST" action="done.html">

+ <input type="text" placeholder="username" />

+ <input type="password" placeholder="password" />

+ <input type="submit" />

+</form>