chrome/test/data/password/ambiguous_password_form.html - Issue 1292693004: [Password Manager] Autofill forms with field name and id attributes missing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/password/ambiguous_password_form.html

Issue 1292693004: [Password Manager] Autofill forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a browser_tests for suggestion popup. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('K') | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/autofill/content/renderer/password_autofill_agent.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <!-- Password form with the username and password fields having ambiguity in id attribute. -->

	3 <form id="ambiguous_form" method="POST" action="done.html">

	4 <label>Username: </label><input type="text" id="ambiguous_id" />

	5 <label>Password: </label><input type="password" id="ambiguous_id" />

	6 <input type="submit" />

	7 </form>

	8

	9 <!-- Password form having username and password fields without name and id attri bute. -->

	10 <form id="no_name_id_form" method="POST" action="done.html">

	11 <label>Username: </label> <input type="text" placeholder="username" />

	12 <label>Password: </label> <input type="password" placeholder="password" />

	13 <input type="submit" />

	14 </form>

	15

	16 <!-- change password form having username and password fields without name and i d attribute. -->

	17 <form id="change_pwd_no_name_id" method="POST" action="done.html">

	18 <label>Username: </label> <input type="text" placeholder="username" />
	vabr (Chromium) 2015/09/18 14:41:38 This looks like a sign-up form, not a change passw This looks like a sign-up form, not a change password form. Pritam Nikam 2015/09/21 10:51:17 Done. Show quoted text On 2015/09/18 14:41:38, vabr (Chromium) wrote: > This looks like a sign-up form, not a change password form. Done.
	19 <label>Password: </label> <input type="password" placeholder="password" />

	20 <label>Confirm Password: </label> <input type="password" placeholder="confirm password" />

	21 <input type="submit" />

	22 </form>

OLD	NEW