[DevTools] Group options in network presets select.

Source/devtools/front_end/settings/SettingsScreen.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 162 matching lines @@
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.SettingsTab}
  */
 WebInspector.GenericSettingsTab = function()
 {
     WebInspector.SettingsTab.call(this, WebInspector.UIString("General"), "general-tab-content");
+    WebInspector.GenericSettingsTab._instance = this;
 
     /** @const */
     var explicitSectionOrder = ["", "Appearance", "Elements", "Sources", "Network", "Profiler", "Console", "Extensions"];
     /** @type {!Map<string, !Element>} */
     this._nameToSection = new Map();
     /** @type {!Map<string, !Element>} */
     this._nameToSettingElement = new Map();
     for (var sectionName of explicitSectionOrder)
         this._sectionElement(sectionName);
     self.runtime.extensions("setting").forEach(this._addSetting.bind(this));
     self.runtime.extensions(WebInspector.SettingUI).forEach(this._addSettingUI.bind(this));
 
     this._appendSection().appendChild(createTextButton(WebInspector.UIString("Restore defaults and reload"), restoreAndReload));
 
     function restoreAndReload()
     {
         WebInspector.settings.clearAll();
         WebInspector.reload();
     }
 }
 
+/** @type {?WebInspector.GenericSettingsTab} */
+WebInspector.GenericSettingsTab._instance;
+
+/**
+ * @param {!Runtime.Extension} extension
+ * @return {boolean}
+ */
+WebInspector.GenericSettingsTab.isSettingVisible = function(extension)
+{
+    var descriptor = extension.descriptor();
+    if (!("title" in descriptor))
+        return false;
+    if (!(("category" in descriptor) || ("parentSettingName" in descriptor)))
+        return false;
+    return true;
+}
+
 WebInspector.GenericSettingsTab.prototype = {
     /**
      * @param {!Runtime.Extension} extension
      */
     _addSetting: function(extension)
     {
+        if (!WebInspector.GenericSettingsTab.isSettingVisible(extension))
+            return;
         var descriptor = extension.descriptor();
-        if (!("title" in descriptor))
-            return;
-        if (!(("category" in descriptor) || ("parentSettingName" in descriptor)))
-            return;
-
         var sectionName = descriptor["category"];
         var settingName = descriptor["settingName"];
         var setting = WebInspector.moduleSetting(settingName);
         var uiTitle = WebInspector.UIString(extension.title(WebInspector.platform()));
 
         var sectionElement = this._sectionElement(sectionName);
         var parentSettingName = descriptor["parentSettingName"];
         var parentSettingElement = parentSettingName ? this._nameToSettingElement.get(descriptor["parentSettingName"]) : null;
         var parentFieldset = null;
         if (parentSettingElement) {
@@ skipping 39 matching lines @@
         extension.instancePromise().then(appendCustomSetting.bind(this));
 
         /**
          * @param {!Object} object
          * @this {WebInspector.GenericSettingsTab}
          */
         function appendCustomSetting(object)
         {
             var settingUI = /** @type {!WebInspector.SettingUI} */ (object);
             var element = settingUI.settingElement();
-            if (element)
-                this._sectionElement(sectionName).appendChild(element);
+            if (!element)
+                return;
+            this._sectionElement(sectionName).appendChild(element);
+
+            var settingsList = descriptor["settings"];
+            if (!settingsList)
+                return;
+            for (var settingName of settingsList) {
+                this._nameToSettingElement.set(settingName, element);
+                if (settingName === this._highlightedSettingName)
+                    this._highlight();
+            }
         }
     },
 
     /**
      * @param {string} sectionName
      * @return {!Element}
      */
     _sectionElement: function(sectionName)
     {
         var sectionElement = this._nameToSection.get(sectionName);
         if (!sectionElement) {
             var uiSectionName = sectionName && WebInspector.UIString(sectionName);
             sectionElement = this._appendSection(uiSectionName);
             this._nameToSection.set(sectionName, sectionElement);
         }
         return sectionElement;
     },
 
+    wasShown: function()
+    {
+        this._highlight();
+    },
+
+    willHide: function()
+    {
+        this._hideHighlight();
+    },
+
+    _hideHighlight: function()
+    {
+        var element = this._highlightedSettingElement();
+        if (element)
+            element.classList.remove("highlighted-setting");
+        delete this._highlightedSettingName;
+    },
+
+    /**
+     * @return {?Element}
+     */
+    _highlightedSettingElement: function()
+    {
+        return this._highlightedSettingName ? (this._nameToSettingElement.get(this._highlightedSettingName) || null) : null;
+    },
+
+    _highlight: function()
+    {
+        var element = this._highlightedSettingElement();
+        if (element) {
+            element.classList.add("highlighted-setting");
+            element.scrollIntoView();
+        }
+    },
+
+    /**
+     * @param {!WebInspector.Setting} setting
+     */
+    highlightSetting: function(setting)
+    {
+        this._hideHighlight();
+        this._highlightedSettingName = setting.name;

[pfeldman, 2015/08/13 23:33:13]

Lets highlight it when we know that it is on screen and not store this state.

+        this._highlight();
+    },
+
     __proto__: WebInspector.SettingsTab.prototype
 }
 
 /**
  * @constructor
  * @implements {WebInspector.SettingUI}
  */
 WebInspector.SettingsScreen.SkipStackFramePatternSettingUI = function()
 {
 }
@@ skipping 296 matching lines @@
             WebInspector._settingsController.showSettingsScreen();
         else if (actionId === "settings.help")
             InspectorFrontendHost.openInNewTab("https://developers.google.com/web/tools/chrome-devtools/");
         else if (actionId === "settings.shortcuts")
             WebInspector._settingsController.showSettingsScreen("shortcuts");
     }
 }
 
 /**
  * @constructor
+ * @implements {WebInspector.Revealer}
+ */
+WebInspector.SettingsController.Revealer = function() { }
+
+WebInspector.SettingsController.Revealer.prototype = {
+    /**
+     * @override
+     * @param {!Object} object
+     * @param {number=} lineNumber
+     * @return {!Promise}
+     */
+    reveal: function(object, lineNumber)
+    {
+        console.assert(object instanceof WebInspector.Setting);
+        var setting = /** @type {!WebInspector.Setting} */ (object);
+        var success = false;
+
+        self.runtime.extensions("setting").forEach(revealModuleSetting);
+        self.runtime.extensions(WebInspector.SettingUI).forEach(revealSettingUI);
+        self.runtime.extensions("settings-view").forEach(revealSettingsView);
+
+        return success ? Promise.resolve() : Promise.reject();
+
+        /**
+         * @param {!Runtime.Extension} extension
+         */
+        function revealModuleSetting(extension)
+        {
+            if (!WebInspector.GenericSettingsTab.isSettingVisible(extension))
+                return;
+            if (extension.descriptor()["settingName"] === setting.name) {
+                WebInspector._settingsController.showSettingsScreen("general");
+                WebInspector.GenericSettingsTab._instance.highlightSetting(setting);
+                success = true;
+            }
+        }
+
+        /**
+         * @param {!Runtime.Extension} extension
+         */
+        function revealSettingUI(extension)
+        {
+            var settings = extension.descriptor()["settings"];
+            if (settings && settings.indexOf(setting.name) !== -1) {
+                WebInspector._settingsController.showSettingsScreen("general");
+                WebInspector.GenericSettingsTab._instance.highlightSetting(setting);
+                success = true;
+            }
+        }
+
+        /**
+         * @param {!Runtime.Extension} extension
+         */
+        function revealSettingsView(extension)
+        {
+            var settings = extension.descriptor()["settings"];
+            if (settings && settings.indexOf(setting.name) !== -1) {
+                WebInspector._settingsController.showSettingsScreen(extension.descriptor()["name"]);
+                success = true;
+            }
+        }
+    }
+}
+
+/**
+ * @constructor
  * @extends {WebInspector.Object}
  * @param {!Array.<{id: string, placeholder: (string|undefined), options: (!Array.<string>|undefined)}>} columns
  * @param {function(!Element, {id: string, placeholder: (string|undefined), options: (!Array.<string>|undefined)}, ?string)} itemRenderer
  */
 WebInspector.SettingsList = function(columns, itemRenderer)
 {
     this.element = createElementWithClass("div", "settings-list");
     this.element.tabIndex = -1;
     this._itemRenderer = itemRenderer;
     /** @type {!Map.<string, !Element>} */
@@ skipping 461 matching lines @@
             var columnId = columns[i];
             var editElement = this._addInputElements.get(columnId);
             this._setEditElementValue(editElement, "");
         }
     },
 
     __proto__: WebInspector.SettingsList.prototype
 }
 
 WebInspector._settingsController = new WebInspector.SettingsController();