Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292673002: [DevTools] Group options in network presets select. (Closed)

Created:
5 years, 4 months ago by dgozman
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Group options in network presets select. Added ability to reveal a setting in settings screen for "Edit" option. BUG=520239 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200789

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed extra reveals #

Patch Set 3 : more cleanup #

Patch Set 4 : Updated visual design #

Total comments: 2

Patch Set 5 : Fixed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -17 lines) Patch
M Source/devtools/front_end/components/NetworkConditionsSelector.js View 1 2 3 4 2 chunks +36 lines, -9 lines 0 comments Download
M Source/devtools/front_end/components/module.json View 1 chunk +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/emulation/module.json View 1 chunk +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/settings/SettingsScreen.js View 1 2 2 chunks +80 lines, -5 lines 0 comments Download
M Source/devtools/front_end/settings/module.json View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
dgozman
Take a look please.
5 years, 4 months ago (2015-08-13 23:07:53 UTC) #2
pfeldman
https://codereview.chromium.org/1292673002/diff/1/Source/devtools/front_end/settings/SettingsScreen.js File Source/devtools/front_end/settings/SettingsScreen.js (right): https://codereview.chromium.org/1292673002/diff/1/Source/devtools/front_end/settings/SettingsScreen.js#newcode361 Source/devtools/front_end/settings/SettingsScreen.js:361: this._highlightedSettingName = setting.name; Lets highlight it when we know ...
5 years, 4 months ago (2015-08-13 23:33:13 UTC) #3
dgozman
PTAL
5 years, 4 months ago (2015-08-13 23:58:02 UTC) #4
dgozman
ping
5 years, 4 months ago (2015-08-15 01:18:17 UTC) #5
pfeldman
lgtm https://codereview.chromium.org/1292673002/diff/60001/Source/devtools/front_end/components/NetworkConditionsSelector.js File Source/devtools/front_end/components/NetworkConditionsSelector.js (right): https://codereview.chromium.org/1292673002/diff/60001/Source/devtools/front_end/components/NetworkConditionsSelector.js#newcode79 Source/devtools/front_end/components/NetworkConditionsSelector.js:79: customGroup.insertBefore(new Option(WebInspector.UIString("Add..."), WebInspector.UIString("Add...")), customGroup.firstChild); Use ellipsis from the ...
5 years, 4 months ago (2015-08-17 19:00:12 UTC) #6
dgozman
https://codereview.chromium.org/1292673002/diff/60001/Source/devtools/front_end/components/NetworkConditionsSelector.js File Source/devtools/front_end/components/NetworkConditionsSelector.js (right): https://codereview.chromium.org/1292673002/diff/60001/Source/devtools/front_end/components/NetworkConditionsSelector.js#newcode79 Source/devtools/front_end/components/NetworkConditionsSelector.js:79: customGroup.insertBefore(new Option(WebInspector.UIString("Add..."), WebInspector.UIString("Add...")), customGroup.firstChild); On 2015/08/17 19:00:12, pfeldman wrote: ...
5 years, 4 months ago (2015-08-19 01:59:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292673002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292673002/80001
5 years, 4 months ago (2015-08-19 01:59:22 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 03:24:15 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200789

Powered by Google App Engine
This is Rietveld 408576698