LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex.html - Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex.html

Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Aligned with maxSelectedItems value Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex.html

diff --git a/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex.html b/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex.html

index 2c3dcfdf07586185ae2446440b3ac4a7703095aa..9e5e7b8dcfa53eaf1b5b104cac27cc3b7bb84744 100644

--- a/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex.html

+++ b/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex.html

@@ -14,7 +14,7 @@ reset(mySelect);

var i = 0;

debug((++i) + ") setting length to a negative length");

-shouldThrow("mySelect.options.length = -1;");

+mySelect.options.length = -1;

shouldBe("mySelect.options.length", "2");

shouldBe("mySelect.selectedIndex", "1");

« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt » ('j') | Source/core/html/HTMLOptionsCollection.cpp » ('J')