Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292613003: Use override in more classes in core/ (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+978 lines, -817 lines) Patch
M core/include/fpdfapi/fpdf_pageobj.h View 1 2 7 chunks +7 lines, -9 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 2 chunks +34 lines, -32 lines 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/include/fpdfdoc/fpdf_ap.h View 1 chunk +13 lines, -14 lines 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M core/include/fpdfdoc/fpdf_vt.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fxge/fpf.h View 2 chunks +7 lines, -3 lines 0 comments Download
M core/include/fxge/fx_dib.h View 10 chunks +47 lines, -44 lines 0 comments Download
M core/include/fxge/fx_font.h View 3 chunks +5 lines, -3 lines 0 comments Download
M core/include/fxge/fx_ge.h View 5 chunks +6 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.h View 5 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 4 chunks +30 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 8 chunks +42 lines, -23 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 7 chunks +11 lines, -10 lines 0 comments Download
M core/src/fpdfdoc/pdf_vt.h View 6 chunks +99 lines, -77 lines 0 comments Download
M core/src/fpdfdoc/tagged_int.h View 3 chunks +25 lines, -19 lines 0 comments Download
M core/src/fpdftext/text_int.h View 5 chunks +64 lines, -62 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 10 chunks +34 lines, -33 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 chunk +8 lines, -5 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 3 chunks +11 lines, -5 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 3 chunks +12 lines, -6 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 3 chunks +18 lines, -8 lines 0 comments Download
M core/src/fxcrt/extension.h View 4 chunks +5 lines, -2 lines 0 comments Download
M core/src/fxcrt/fxcrt_platforms.h View 1 chunk +18 lines, -16 lines 0 comments Download
M core/src/fxcrt/fxcrt_posix.h View 1 chunk +18 lines, -16 lines 0 comments Download
M core/src/fxcrt/fxcrt_windows.h View 1 chunk +18 lines, -16 lines 0 comments Download
M core/src/fxcrt/xml_int.h View 6 chunks +26 lines, -18 lines 0 comments Download
M core/src/fxge/agg/include/fx_agg_driver.h View 1 chunk +90 lines, -99 lines 0 comments Download
M core/src/fxge/android/fpf_skiafont.h View 1 chunk +24 lines, -25 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.h View 5 chunks +35 lines, -14 lines 0 comments Download
M core/src/fxge/android/fpf_skiamodule.h View 1 chunk +10 lines, -4 lines 0 comments Download
M core/src/fxge/apple/apple_int.h View 4 chunks +102 lines, -96 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 2 chunks +21 lines, -17 lines 0 comments Download
M core/src/fxge/win32/win32_int.h View 4 chunks +110 lines, -95 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
5 years, 4 months ago (2015-08-14 18:53:28 UTC) #3
Tom Sepez
lgtm https://codereview.chromium.org/1292613003/diff/20001/core/include/fpdfapi/fpdf_pageobj.h File core/include/fpdfapi/fpdf_pageobj.h (right): https://codereview.chromium.org/1292613003/diff/20001/core/include/fpdfapi/fpdf_pageobj.h#newcode493 core/include/fpdfapi/fpdf_pageobj.h:493: CPDF_PathObject() { m_Type = PDFPAGE_PATH; } nit: Bleh. ...
5 years, 4 months ago (2015-08-14 20:15:53 UTC) #4
Lei Zhang
Committed patchset #3 (id:60001) manually as c2c3f7b5f0396409451a9d344f35ec1929a76e9f (presubmit successful).
5 years, 4 months ago (2015-08-14 21:07:47 UTC) #5
Lei Zhang
5 years, 4 months ago (2015-08-14 21:09:26 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1292613003/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_pageobj.h (right):

https://codereview.chromium.org/1292613003/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_pageobj.h:493: CPDF_PathObject() { m_Type =
PDFPAGE_PATH; }
On 2015/08/14 20:15:52, Tom Sepez wrote:
> nit: Bleh.  constructor setting superclass members? CPDF_PageObject() ctor
> should take a type? For followup.

Ya, I'll do a follow up.

https://codereview.chromium.org/1292613003/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_pageobj.h:508: void CalcBoundingBox();
On 2015/08/14 20:15:52, Tom Sepez wrote:
> nit: methods before members.

Done.

Powered by Google App Engine
This is Rietveld 408576698