Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: src/ports/SkFontHost_fontconfig.cpp

Issue 12926004: When we read from a RemoteFontStream (might happen maybe with other streams), stream's data might b… (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkFontHost_fontconfig.cpp
===================================================================
--- src/ports/SkFontHost_fontconfig.cpp (revision 8280)
+++ src/ports/SkFontHost_fontconfig.cpp (working copy)
@@ -247,6 +247,13 @@
static SkStream* open_stream(const FontConfigTypeface* face, int* ttcIndex) {
SkStream* stream = face->getLocalStream();
if (stream) {
+ // TODO: fix issue 1176.
+ // As of now open_stream will return a stream and unwind it, but the
+ // SkStream is not thread safe, and if two threads use the stream they
+ // may collide and print preview for example could still fail,
+ // or there could be some failures in rendering if this stream is used
+ // there.
+ stream->rewind();
stream->ref();
// should have been provided by CreateFromStream()
*ttcIndex = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698