Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: Source/WebCore/bindings/v8/ScriptValue.cpp

Issue 12926003: Merge 144458 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/bindings/v8/ScriptValue.h ('k') | Source/WebCore/bindings/v8/SharedPersistent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/bindings/v8/ScriptValue.cpp
===================================================================
--- Source/WebCore/bindings/v8/ScriptValue.cpp (revision 146152)
+++ Source/WebCore/bindings/v8/ScriptValue.cpp (working copy)
@@ -47,13 +47,13 @@
PassRefPtr<SerializedScriptValue> ScriptValue::serialize(ScriptState* scriptState)
{
ScriptScope scope(scriptState);
- return SerializedScriptValue::create(v8Value());
+ return SerializedScriptValue::create(v8ValueRaw());
}
PassRefPtr<SerializedScriptValue> ScriptValue::serialize(ScriptState* scriptState, MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, bool& didThrow)
{
ScriptScope scope(scriptState);
- return SerializedScriptValue::create(v8Value(), messagePorts, arrayBuffers, didThrow);
+ return SerializedScriptValue::create(v8ValueRaw(), messagePorts, arrayBuffers, didThrow);
}
ScriptValue ScriptValue::deserialize(ScriptState* scriptState, SerializedScriptValue* value)
@@ -64,20 +64,20 @@
bool ScriptValue::getString(String& result) const
{
- if (m_value.isEmpty())
+ if (hasNoValue())
return false;
- if (!m_value->IsString())
+ if (!v8ValueRaw()->IsString())
return false;
- result = toWebCoreString(m_value.get());
+ result = toWebCoreString(v8ValueRaw());
return true;
}
String ScriptValue::toString(ScriptState*) const
{
v8::TryCatch block;
- v8::Handle<v8::String> string = m_value->ToString();
+ v8::Handle<v8::String> string = v8ValueRaw()->ToString();
if (block.HasCaught())
return String();
return v8StringToWebCoreString<String>(string, DoNotExternalize);
@@ -142,7 +142,7 @@
v8::HandleScope handleScope;
// v8::Object::GetPropertyNames() expects current context to be not null.
v8::Context::Scope contextScope(scriptState->context());
- return v8ToInspectorValue(m_value.get(), InspectorValue::maxDepth);
+ return v8ToInspectorValue(v8ValueRaw(), InspectorValue::maxDepth);
}
#endif
« no previous file with comments | « Source/WebCore/bindings/v8/ScriptValue.h ('k') | Source/WebCore/bindings/v8/SharedPersistent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698