Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292593003: Revert "Revert "Reland 2: mac: Use a placeholder string for the family name of the system font." Br… (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
4 years, 5 months ago
Reviewers:
keishi, tkent, Nico
CC:
blink-reviews, blink-reviews-rendering, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Revert "Reland 2: mac: Use a placeholder string for the family name of the system font." Branch 2485" I had intended to revert the CL on branch 2485, but the CQ sent it straight to trunk. Undoing the revert. TBR=tkent@chromium.org, keishi@chromium.org, thakis@chromium.org NOTRY=true NOPRESUBMIT=true BUG=515989, 515836 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -60 lines) Patch
M Source/core/layout/LayoutTextControlMultiLine.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTextControlSingleLine.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/layout/LayoutTheme.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutThemeMac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutThemeMac.mm View 3 chunks +10 lines, -2 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/platform/fonts/mac/FontCacheMac.mm View 3 chunks +3 lines, -19 lines 0 comments Download
M Source/platform/fonts/mac/FontFamilyMatcherMac.h View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/platform/fonts/mac/FontFamilyMatcherMac.mm View 7 chunks +84 lines, -5 lines 0 comments Download
A Source/platform/fonts/mac/FontFamilyMatcherMacTest.mm View 1 chunk +41 lines, -0 lines 0 comments Download
M Source/platform/mac/ThemeMac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/mac/ThemeMac.mm View 2 chunks +1 line, -13 lines 0 comments Download
A Source/platform/mac/VersionUtilMac.h View 1 chunk +18 lines, -0 lines 0 comments Download
A Source/platform/mac/VersionUtilMac.mm View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292593003/1
5 years, 4 months ago (2015-08-17 21:06:14 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 21:06:57 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200666

Powered by Google App Engine
This is Rietveld 408576698