Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1292583006: Revert of Add Unicode Variation Selector support on Linux official builds (Closed)

Created:
5 years, 4 months ago by rsadam
Modified:
5 years, 4 months ago
Reviewers:
drott, kojii, eae
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add Unicode Variation Selector support on Linux official builds (patchset #1 id:1 of https://codereview.chromium.org/1283923002/ ) Reason for revert: This CL prevents building official Chrome images on Linux. ../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp:176:13: error: use of undeclared identifier 'hb_ot_font_set_funcs' The proposed workaround doesn't work, so reverting this CL. Original issue's description: > Add Unicode Variation Selector support on Linux official builds > > Most of the work to support Unicode Variation Selector was done in a > separate CL[1], but it was not enabled for Linux due to crbug.com/462689. > > This patch enables the Unicode Variation Selector support on Linux > official builds. > > The CL to enable on all Linux[2] was reverted because chromeos=1 is still > bound to the harfbuzz in the system and thus unable to use > hb_ot_font_set_funcs() on Trusty. > > [1] https://codereview.chromium.org/1149693002/ > [2] https://codereview.chromium.org/1209043010/ > > BUG=383580 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200427 TBR=eae@chromium.org,drott@chromium.org,kojii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=383580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/platform/fonts/shaping/HarfBuzzFace.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rsadam
Created Revert of Add Unicode Variation Selector support on Linux official builds
5 years, 4 months ago (2015-08-18 19:45:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292583006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292583006/1
5 years, 4 months ago (2015-08-18 19:45:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200747
5 years, 4 months ago (2015-08-18 19:45:58 UTC) #3
kojii
5 years, 4 months ago (2015-08-19 01:38:37 UTC) #4
Message was sent while issue was closed.
On 2015/08/18 19:45:58, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=200747

LGTM, sorry for the trouble.

Powered by Google App Engine
This is Rietveld 408576698