Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292533005: Remove heap-inl.h include from natives.h. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove heap-inl.h include from natives.h. R=mstarzinger@chromium.org

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : fix again. argh templates. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -40 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/snapshot/natives.h View 1 2 3 chunks +10 lines, -40 lines 1 comment Download
A src/snapshot/natives-common.cc View 1 2 1 chunk +50 lines, -0 lines 1 comment Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Yang
5 years, 4 months ago (2015-08-18 07:35:51 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292533005/1
5 years, 4 months ago (2015-08-18 07:42:18 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/7674)
5 years, 4 months ago (2015-08-18 07:49:00 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292533005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292533005/20001
5 years, 4 months ago (2015-08-18 08:02:33 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/3355) v8_linux64_rel on ...
5 years, 4 months ago (2015-08-18 08:06:04 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292533005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292533005/40001
5 years, 4 months ago (2015-08-18 08:29:42 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 08:54:19 UTC) #13
Michael Starzinger
5 years, 4 months ago (2015-08-18 12:05:56 UTC) #14 
Please see my suggestion: https://codereview.chromium.org/1303463002/

https://codereview.chromium.org/1292533005/diff/40001/src/snapshot/natives-co...
File src/snapshot/natives-common.cc (right):

https://codereview.chromium.org/1292533005/diff/40001/src/snapshot/natives-co...
src/snapshot/natives-common.cc:15: FixedArray*
NativesCollectionBase<type>::GetSourceCache(Heap* heap) {
First trying to templatize NativesCollection and then having a switch over the
template parameter doesn't make much sense to me. What was wrong to patch set #2
without dropping the explicit declarations from natives-external.cc?

https://codereview.chromium.org/1292533005/diff/40001/src/snapshot/natives.h
File src/snapshot/natives.h (right):

https://codereview.chromium.org/1292533005/diff/40001/src/snapshot/natives.h#...
src/snapshot/natives.h:9: #include "src/heap/heap-inl.h"
Please also actually remove the includes.

Powered by Google App Engine
This is Rietveld 408576698