Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 129253003: Revert of Create signin component and componentize TokenWebData. (Closed)

Created:
6 years, 11 months ago by Noam Samuel
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, benquan, haitaol+watch_chromium.org, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, rsimha+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/109783003/ Reason for revert: ChromeOS bot failures, example http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/19049 Failing lines: /tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry [ FAILED ] /tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',) /tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry [ FAILED ] /tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',) TBR=joi@chromium.org,rogerta@chromium.org,tfarina@chromium.org,thakis@chromium.org,blundell@chromium.org NOTREECHECKS=true NOTRY=true BUG=332107 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -564 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service.cc View 6 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
A chrome/browser/webdata/token_service_table.h View 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/webdata/token_service_table.cc View 1 chunk +116 lines, -0 lines 0 comments Download
A chrome/browser/webdata/token_service_table_unittest.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A chrome/browser/webdata/token_web_data.h View 1 chunk +69 lines, -0 lines 0 comments Download
A chrome/browser/webdata/token_web_data.cc View 1 chunk +110 lines, -0 lines 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 5 chunks +19 lines, -16 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
D components/signin.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/signin/DEPS View 1 chunk +0 lines, -14 lines 0 comments Download
D components/signin/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/signin/README View 1 chunk +0 lines, -9 lines 0 comments Download
D components/signin/core/webdata/token_service_table.h View 1 chunk +0 lines, -51 lines 0 comments Download
D components/signin/core/webdata/token_service_table.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D components/signin/core/webdata/token_service_table_unittest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D components/signin/core/webdata/token_web_data.h View 1 chunk +0 lines, -70 lines 0 comments Download
D components/signin/core/webdata/token_web_data.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M components/webdata/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/webdata/common/web_data_service_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Noam Samuel
Created Revert of Create signin component and componentize TokenWebData.
6 years, 11 months ago (2014-01-08 22:15:43 UTC) #1
Nico
Hi, when reverting CLs, please always include enough detail in the revert message that the ...
6 years, 11 months ago (2014-01-08 22:17:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/129253003/1
6 years, 11 months ago (2014-01-08 22:19:19 UTC) #3
Nico
On 2014/01/08 22:19:19, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 11 months ago (2014-01-08 22:22:09 UTC) #4
Noam Samuel
On 2014/01/08 22:22:09, Nico wrote: > On 2014/01/08 22:19:19, I haz the power (commit-bot) wrote: ...
6 years, 11 months ago (2014-01-08 22:44:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/129253003/1
6 years, 11 months ago (2014-01-08 22:48:38 UTC) #6
Nico
lgtm, thank you :-)
6 years, 11 months ago (2014-01-08 23:05:13 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 23:08:50 UTC) #8
Message was sent while issue was closed.
Change committed as 243687

Powered by Google App Engine
This is Rietveld 408576698