Create custom scrollbars when html element has overflow:scroll

Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp

Index: Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
diff --git a/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp b/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
index 75b2999646e092109c931114f7a27add34ba4c50..7ebf7b56cbb5f6c0586816af551d16dae0ef48cb 100644
--- a/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
+++ b/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
@@ -646,6 +646,13 @@ void DeprecatedPaintLayerScrollableArea::updateAfterLayout()
 {
     ASSERT(box().hasOverflowClip());
 
+    if (needsScrollbarReconstruction()) {
+        if (m_hBar)
+            destroyScrollbar(HorizontalScrollbar);
+        if (m_vBar)
+            destroyScrollbar(VerticalScrollbar);
+    }
+
     DoubleSize originalScrollOffset = adjustedScrollOffset();
     computeScrollDimensions();
 
@@ -679,15 +686,18 @@ void DeprecatedPaintLayerScrollableArea::updateAfterLayout()
         if (!scrollSize(VerticalScrollbar))
             setHasVerticalScrollbar(false);
     }
-    // overflow:auto may need to lay out again if scrollbars got added/removed.
-    bool autoHorizontalScrollBarChanged = box().hasAutoHorizontalScrollbar() && (hasHorizontalScrollbar() != hasHorizontalOverflow);
-    bool autoVerticalScrollBarChanged = box().hasAutoVerticalScrollbar() && (hasVerticalScrollbar() != hasVerticalOverflow);
 
-    if (!visualViewportSuppliesScrollbars() && (autoHorizontalScrollBarChanged || autoVerticalScrollBarChanged)) {
-        if (box().hasAutoHorizontalScrollbar())
-            setHasHorizontalScrollbar(hasHorizontalOverflow);
-        if (box().hasAutoVerticalScrollbar())
-            setHasVerticalScrollbar(hasVerticalOverflow);
+    // We need to layout again if scrollbars are added or removed by overflow:auto,
+    // or by changing between native and custom.
+    bool horizontalScrollBarChanged = (box().hasAutoHorizontalScrollbar() && (hasHorizontalScrollbar() != hasHorizontalOverflow))
+        || (box().style()->overflowX() == OSCROLL && !horizontalScrollbar() && !ScrollbarTheme::theme()->usesOverlayScrollbars());

[skobes, 2015/08/20 19:44:02]

Won't this fail to reconstruct in the case where we switch from custom back to
(overlay) native and scrollSize returns > 0?

[MuVen, 2015/08/21 14:27:38]

True, this logic goes for toss when switching from custom to overlay. I have
moved the logic of destroying the scroll-bars when we cant scroll in that
orientation. This should be fine. PTAL.

+    bool verticalScrollBarChanged = (box().hasAutoVerticalScrollbar() && (hasVerticalScrollbar() != hasVerticalOverflow))
+        || (box().style()->overflowY() == OSCROLL && !verticalScrollbar() && !ScrollbarTheme::theme()->usesOverlayScrollbars());
+    if (!visualViewportSuppliesScrollbars() && (horizontalScrollBarChanged || verticalScrollBarChanged)) {
+        if (box().hasAutoHorizontalScrollbar() || (box().style()->overflowX() == OSCROLL && !horizontalScrollbar()))
+            setHasHorizontalScrollbar(box().style()->overflowX() == OSCROLL ? true : hasHorizontalOverflow);
+        if (box().hasAutoVerticalScrollbar() || (box().style()->overflowY() == OSCROLL && !verticalScrollbar()))
+            setHasVerticalScrollbar(box().style()->overflowY() == OSCROLL ? true : hasVerticalOverflow);
 
         if (hasVerticalOverflow || hasHorizontalOverflow)
             updateScrollCornerStyle();
@@ -698,15 +708,15 @@ void DeprecatedPaintLayerScrollableArea::updateAfterLayout()
         if (box().document().hasAnnotatedRegions())
             box().document().setAnnotatedRegionsDirty(true);
 
-        if (box().style()->overflowX() == OAUTO || box().style()->overflowY() == OAUTO) {
+        // Our proprietary overflow: overlay value doesn't trigger a layout.
+        if ((horizontalScrollBarChanged && box().style()->overflowX() != OOVERLAY) || (verticalScrollBarChanged && box().style()->overflowY() != OOVERLAY)) {
             if (!m_inOverflowRelayout) {
-                // Our proprietary overflow: overlay value doesn't trigger a layout.
                 m_inOverflowRelayout = true;
                 SubtreeLayoutScope layoutScope(box());
                 layoutScope.setNeedsLayout(&box(), LayoutInvalidationReason::ScrollbarChanged);
                 if (box().isLayoutBlock()) {
                     LayoutBlock& block = toLayoutBlock(box());
-                    block.scrollbarsChanged(autoHorizontalScrollBarChanged, autoVerticalScrollBarChanged);
+                    block.scrollbarsChanged(horizontalScrollBarChanged, verticalScrollBarChanged);
                     block.layoutBlock(true);
                 } else {
                     box().layout();
@@ -958,6 +968,15 @@ static inline LayoutObject* layoutObjectForScrollbar(LayoutObject& layoutObject)
     return &layoutObject;
 }
 
+bool DeprecatedPaintLayerScrollableArea::needsScrollbarReconstruction() const
+{
+    LayoutObject* actualLayoutObject = layoutObjectForScrollbar(box());
+    bool shouldUseCustom = actualLayoutObject->isBox() && actualLayoutObject->style()->hasPseudoStyle(SCROLLBAR);
+    bool hasAnyScrollbar = hasScrollbar();
+    bool hasCustom = (m_hBar && m_hBar->isCustomScrollbar()) || (m_vBar && m_vBar->isCustomScrollbar());
+    return hasAnyScrollbar && (shouldUseCustom != hasCustom);
+}
+
 PassRefPtrWillBeRawPtr<Scrollbar> DeprecatedPaintLayerScrollableArea::createScrollbar(ScrollbarOrientation orientation)
 {
     RefPtrWillBeRawPtr<Scrollbar> widget = nullptr;