Create custom scrollbars when html element has overflow:scroll

Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 628 matching lines @@
     if (newScrollOffset != adjustedScrollOffset()) {
         DoublePoint origin(scrollOrigin());
         ScrollableArea::setScrollPosition(-origin + newScrollOffset, ProgrammaticScroll, scrollBehavior);
     }
 }
 
 void DeprecatedPaintLayerScrollableArea::updateAfterLayout()
 {
     ASSERT(box().hasOverflowClip());
 
+    bool needsHBarConstruction = false;
+    bool needsVBarConstruction = false;
+    if (needsScrollbarReconstruction()) {
+        if (m_hBar) {
+            destroyScrollbar(HorizontalScrollbar);
+            needsHBarConstruction = true;

[skobes, 2015/08/14 19:02:56]

I don't understand the need to store this.  Why doesn't the existing
overflow:auto logic create the scrollbar?

+        }
+        if (m_vBar) {
+            destroyScrollbar(VerticalScrollbar);
+            needsVBarConstruction = true;
+        }
+    }
+
     DoubleSize originalScrollOffset = adjustedScrollOffset();
     computeScrollDimensions();
 
     // Layout may cause us to be at an invalid scroll position. In this case we need
     // to pull our scroll offsets back to the max (or push them up to the min).
     DoubleSize clampedScrollOffset = clampScrollOffset(adjustedScrollOffset());
     if (clampedScrollOffset != adjustedScrollOffset())
         scrollToOffset(clampedScrollOffset);
 
     if (originalScrollOffset != adjustedScrollOffset()) {
@@ skipping 13 matching lines @@
             horizontalScrollbar()->setEnabled(hasHorizontalOverflow);
         if (box().style()->overflowY() == OSCROLL && verticalScrollbar())
             verticalScrollbar()->setEnabled(hasVerticalOverflow);
     }
     if (hasOverlayScrollbars()) {
         if (!scrollSize(HorizontalScrollbar))
             setHasHorizontalScrollbar(false);
         if (!scrollSize(VerticalScrollbar))
             setHasVerticalScrollbar(false);
     }
-    // overflow:auto may need to lay out again if scrollbars got added/removed.
-    bool autoHorizontalScrollBarChanged = box().hasAutoHorizontalScrollbar() && (hasHorizontalScrollbar() != hasHorizontalOverflow);
-    bool autoVerticalScrollBarChanged = box().hasAutoVerticalScrollbar() && (hasVerticalScrollbar() != hasVerticalOverflow);
+    // overflow:auto may need to lay out again if scrollbars got added/removed. And even on reconstruction of scrollbars
+    // from native to custom or vice versa may also need to layout again.
+    bool horizontalScrollBarChanged = (box().hasAutoHorizontalScrollbar() && (hasHorizontalScrollbar() != hasHorizontalOverflow)) || needsHBarConstruction;

[skobes, 2015/08/14 19:23:37]

Oh I see, the problem is with overflow:scroll and not overflow:auto.

I think you can still avoid the needsHBarConstruction and needsVBarConstruction
vars.  Can we use

bool horizontalScrollBarChanged = (box().hasAutoHorizontalScrollbar() &&
(hasHorizontalScrollbar() != hasHorizontalOverflow))
    || (box().style()->overflowX() == OSCROLL && !horizontalScrollbar());
...?

[MuVen, 2015/08/17 09:21:03]

Done.

+    bool verticalScrollBarChanged = (box().hasAutoVerticalScrollbar() && (hasVerticalScrollbar() != hasVerticalOverflow)) || needsVBarConstruction;
 
-    if (!visualViewportSuppliesScrollbars() && (autoHorizontalScrollBarChanged || autoVerticalScrollBarChanged)) {
-        if (box().hasAutoHorizontalScrollbar())
+    if (!visualViewportSuppliesScrollbars() && (horizontalScrollBarChanged || verticalScrollBarChanged)) {
+        if (box().hasAutoHorizontalScrollbar() || needsHBarConstruction)
             setHasHorizontalScrollbar(hasHorizontalOverflow);
-        if (box().hasAutoVerticalScrollbar())
+        if (box().hasAutoVerticalScrollbar() || needsVBarConstruction)
             setHasVerticalScrollbar(hasVerticalOverflow);
 
         if (hasVerticalOverflow || hasHorizontalOverflow)
             updateScrollCornerStyle();
 
         layer()->updateSelfPaintingLayer();
 
         // Force an update since we know the scrollbars have changed things.
         if (box().document().hasAnnotatedRegions())
             box().document().setAnnotatedRegionsDirty(true);
 
-        if (box().style()->overflowX() == OAUTO || box().style()->overflowY() == OAUTO) {
+        if (box().style()->overflowX() == OAUTO || box().style()->overflowY() == OAUTO || needsHBarConstruction || needsVBarConstruction) {
             if (!m_inOverflowRelayout) {
                 // Our proprietary overflow: overlay value doesn't trigger a layout.
                 m_inOverflowRelayout = true;
                 SubtreeLayoutScope layoutScope(box());
                 layoutScope.setNeedsLayout(&box(), LayoutInvalidationReason::ScrollbarChanged);
                 if (box().isLayoutBlock()) {
                     LayoutBlock& block = toLayoutBlock(box());
-                    block.scrollbarsChanged(autoHorizontalScrollBarChanged, autoVerticalScrollBarChanged);
+                    block.scrollbarsChanged(horizontalScrollBarChanged, verticalScrollBarChanged);
                     block.layoutBlock(true);
                 } else {
                     box().layout();
                 }
                 m_inOverflowRelayout = false;
             }
         }
     }
 
     {
@@ skipping 231 matching lines @@
         }
         if (ShadowRoot* shadowRoot = node->containingShadowRoot()) {
             if (shadowRoot->type() == ShadowRootType::UserAgent)
                 return shadowRoot->host()->layoutObject();
         }
     }
 
     return &layoutObject;
 }
 
+bool DeprecatedPaintLayerScrollableArea::needsScrollbarReconstruction() const
+{
+    LayoutObject* actualLayoutObject = layoutObjectForScrollbar(box());
+    bool shouldUseCustom = actualLayoutObject->isBox() && actualLayoutObject->style()->hasPseudoStyle(SCROLLBAR);
+    bool hasAnyScrollbar = hasScrollbar();
+    bool hasCustom = (m_hBar && m_hBar->isCustomScrollbar()) || (m_vBar && m_vBar->isCustomScrollbar());
+    return hasAnyScrollbar && (shouldUseCustom != hasCustom);
+}
+
 PassRefPtrWillBeRawPtr<Scrollbar> DeprecatedPaintLayerScrollableArea::createScrollbar(ScrollbarOrientation orientation)
 {
     RefPtrWillBeRawPtr<Scrollbar> widget = nullptr;
     LayoutObject* actualLayoutObject = layoutObjectForScrollbar(box());
     bool hasCustomScrollbarStyle = actualLayoutObject->isBox() && actualLayoutObject->style()->hasPseudoStyle(SCROLLBAR);
     if (hasCustomScrollbarStyle) {
         widget = LayoutScrollbar::createCustomScrollbar(this, orientation, actualLayoutObject->node());
     } else {
         ScrollbarControlSize scrollbarSize = RegularScrollbar;
         if (actualLayoutObject->style()->hasAppearance())
@@ skipping 480 matching lines @@
         return false;
 
     LocalFrame* frame = box().frame();
     if (!frame || !frame->isMainFrame() || !frame->settings())
         return false;
 
     return frame->settings()->viewportMetaEnabled();
 }
 
 } // namespace blink