Issue 1292503005: Don't use strtok_s for mingw builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1292503005: Don't use strtok_s for mingw builds (Closed)

Created:
5 years, 4 months ago by Ted Mielczarek

Modified:
5 years, 4 months ago

Reviewers:
ivanpe

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

I'm compiling the processor code with MinGW, and I ran into an issue where strtok_s isn't available in MSVCRT on Windows XP. MinGW provides a strtok_r that works, so I just switched the ifdefs for strtok_r to check for MSVC instead of Windows.

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -2 lines)			Patch
M	src/processor/basic_source_line_resolver.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/processor/cfi_frame_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/processor/tokenize.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages