Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: Source/core/html/HTMLScriptElement.cpp

Issue 1292503003: Setting empty script text should remove child node of script element (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated as per review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 return InsertionShouldCallDidNotifySubtreeInsertions; 121 return InsertionShouldCallDidNotifySubtreeInsertions;
122 } 122 }
123 123
124 void HTMLScriptElement::didNotifySubtreeInsertionsToDocument() 124 void HTMLScriptElement::didNotifySubtreeInsertionsToDocument()
125 { 125 {
126 m_loader->didNotifySubtreeInsertionsToDocument(); 126 m_loader->didNotifySubtreeInsertionsToDocument();
127 } 127 }
128 128
129 void HTMLScriptElement::setText(const String &value) 129 void HTMLScriptElement::setText(const String &value)
130 { 130 {
131 RefPtrWillBeRawPtr<Node> protectFromMutationEvents(this); 131 RefPtrWillBeRawPtr<Node> protectFromMutationEvents(this);
tkent 2015/08/19 08:11:21 This line is unnecessary. setTextContent has simi
ramya.v 2015/08/19 08:14:18 Done.
132 132 setTextContent(value);
133 if (hasOneTextChild()) {
134 toText(firstChild())->setData(value);
135 return;
136 }
137
138 removeChildren();
139 appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION);
140 } 133 }
141 134
142 void HTMLScriptElement::setAsync(bool async) 135 void HTMLScriptElement::setAsync(bool async)
143 { 136 {
144 setBooleanAttribute(asyncAttr, async); 137 setBooleanAttribute(asyncAttr, async);
145 m_loader->handleAsyncAttribute(); 138 m_loader->handleAsyncAttribute();
146 } 139 }
147 140
148 bool HTMLScriptElement::async() const 141 bool HTMLScriptElement::async() const
149 { 142 {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 return adoptRefWillBeNoop(new HTMLScriptElement(document(), false, m_loader- >alreadyStarted())); 204 return adoptRefWillBeNoop(new HTMLScriptElement(document(), false, m_loader- >alreadyStarted()));
212 } 205 }
213 206
214 DEFINE_TRACE(HTMLScriptElement) 207 DEFINE_TRACE(HTMLScriptElement)
215 { 208 {
216 visitor->trace(m_loader); 209 visitor->trace(m_loader);
217 HTMLElement::trace(visitor); 210 HTMLElement::trace(visitor);
218 } 211 }
219 212
220 } 213 }
OLDNEW
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698