Setting empty script text should remove child node of script element

Source/core/html/HTMLScriptElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 110 matching lines @@
     return InsertionShouldCallDidNotifySubtreeInsertions;
 }
 
 void HTMLScriptElement::didNotifySubtreeInsertionsToDocument()
 {
     m_loader->didNotifySubtreeInsertionsToDocument();
 }
 
 void HTMLScriptElement::setText(const String &value)
 {
     RefPtrWillBeRawPtr<Node> protectFromMutationEvents(this);

[tkent, 2015/08/19 00:11:26]

Can we just call setTextContent(value), and add isEmpty() check to
Node::setTextContent()?

[ramya.v, 2015/08/19 08:08:42]

Modified code to call setTextContent. isEmpty() check is already present in
Node::setTextContent.
Done.

 
+    if (value.isEmpty()) {
+        removeChildren();
+        return;
+    }
+
     if (hasOneTextChild()) {
         toText(firstChild())->setData(value);
         return;
     }
 
     removeChildren();
     appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION);
 }
 
 void HTMLScriptElement::setAsync(bool async)
@@ skipping 68 matching lines @@
     return adoptRefWillBeNoop(new HTMLScriptElement(document(), false, m_loader->alreadyStarted()));
 }
 
 DEFINE_TRACE(HTMLScriptElement)
 {
     visitor->trace(m_loader);
     HTMLElement::trace(visitor);
 }
 
 }