Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292503002: [Fetch] Unship Request.context (Closed)

Created:
5 years, 4 months ago by hiroshige
Modified:
5 years, 4 months ago
Reviewers:
falken, shiva.jm, yhirano
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, shiva.jm
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch] Unship Request.context This is partial revert of https://codereview.chromium.org/1060033002. This CL unships Request.context because it was removed from the spec: https://github.com/whatwg/fetch/issues/93 This CL - removes Response.context from Request.idl, and - updated/removed related Layout tests. Underlying implementation is left unchanged to be reused for Response.type. BUG=515786 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200974

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -102 lines) Patch
M LayoutTests/http/tests/fetch/chromium/error-messages.html View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/fetch/chromium/error-messages-expected.txt View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/fetch.js View 1 2 3 4 5 7 chunks +0 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/request.js View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-request-resources.html View 1 2 3 4 8 chunks +34 lines, -61 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-request-resources-worker.js View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-worker.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/fetch/Request.idl View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
hiroshige
PTAL.
5 years, 4 months ago (2015-08-13 11:37:28 UTC) #2
falken
This lgtm, can you add a small comment to the CL description about why it's ...
5 years, 4 months ago (2015-08-13 11:42:19 UTC) #4
hiroshige
> This lgtm, can you add a small comment to the CL description about why ...
5 years, 4 months ago (2015-08-13 12:04:44 UTC) #5
yhirano
lgtm
5 years, 4 months ago (2015-08-17 03:45:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292503002/40001
5 years, 4 months ago (2015-08-21 05:34:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/87891) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-21 05:35:57 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292503002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292503002/80001
5 years, 4 months ago (2015-08-21 05:57:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292503002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292503002/100001
5 years, 4 months ago (2015-08-21 06:10:26 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 08:09:16 UTC) #16
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200974

Powered by Google App Engine
This is Rietveld 408576698