chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java - Issue 1292493002: Add signals to make callback more reliable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1292493002: Add signals to make callback more reliable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

index 3e426661990a58e7c9365e74507822700eecacde..d28fedccfe0c505cef7927fc2bb28675c9f29c13 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

@@ -226,6 +226,7 @@ public class CustomTabActivity extends ChromeActivity {

@Override

public void onStopWithNative() {

super.onStopWithNative();

+ if (getActivityTab() != null) getActivityTab().hide();

Benoit L 2015/08/13 08:18:18 Should we do something in onPause() rather?

Yusuf 2015/08/13 17:28:18 OK, moved the signal to onPause. Also after talkin

setActiveContentHandler(null);

}

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java ('k') | no next file » | no next file with comments »