Issue 129243003: Clear testing callbacks in AppBackgrounPageNaclTest reentrantly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 129243003: Clear testing callbacks in AppBackgrounPageNaclTest reentrantly. (Closed)

Created:
6 years, 11 months ago by scheib

Modified:
6 years, 11 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clear testing callbacks in AppBackgrounPageNaclTest reentrantly. Addresses a flaky ASAN failure where I believe callbacks from ImpulseCallbackCounter with an unretained reference were being held too long by ProcessManager. This clears the callbacks immediately when the impulse count is reached, and does not call the quit closure repeatedly. BUG=332440 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244247

Patch Set 1 : copy callbacks before run #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -15 lines)			Patch
	M	chrome/browser/extensions/app_background_page_apitest.cc	View		5 chunks	+11 lines, -11 lines	0 comments	Download
	M	extensions/browser/process_manager.cc	View		2 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/129243003/80001

6 years, 11 months ago (2014-01-10 18:20:56 UTC) #3

Message was sent while issue was closed.

Change committed as 244247

Expand Messages | Collapse Messages