Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1292403004: Route browser reload command to DevTools if present. (Closed)

Created:
5 years, 4 months ago by dgozman
Modified:
5 years, 4 months ago
Reviewers:
sky, pfeldman
CC:
chromium-reviews, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Route browser reload command to DevTools if present. DevTools augments reloading with extra actions like recording the timeline. Let reload go through DevTools if browser command triggered it, similarly to how it already goes for Ctrl+R shortcut. BUG=521057 Committed: https://crrev.com/3030f314d43c2ca51cff507f92911e03067dbecf Cr-Commit-Position: refs/heads/master@{#343608}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dgozman
Could you please take a look?
5 years, 4 months ago (2015-08-14 18:37:21 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1292403004/diff/1/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/1292403004/diff/1/chrome/browser/devtools/devtools_window.cc#newcode1245 chrome/browser/devtools/devtools_window.cc:1245: bindings_->CallClientFunction("DevToolsAPI.reload", requestReload? reloadInspectedPage?
5 years, 4 months ago (2015-08-14 18:40:40 UTC) #3
sky
LGTM https://codereview.chromium.org/1292403004/diff/1/chrome/browser/ui/browser_commands.cc File chrome/browser/ui/browser_commands.cc (right): https://codereview.chromium.org/1292403004/diff/1/chrome/browser/ui/browser_commands.cc#newcode222 chrome/browser/ui/browser_commands.cc:222: devtools->ReloadInspectedWebContents(ignore_cache); nit: spacing is off.
5 years, 4 months ago (2015-08-14 20:04:31 UTC) #4
dgozman
https://codereview.chromium.org/1292403004/diff/1/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/1292403004/diff/1/chrome/browser/devtools/devtools_window.cc#newcode1245 chrome/browser/devtools/devtools_window.cc:1245: bindings_->CallClientFunction("DevToolsAPI.reload", On 2015/08/14 18:40:40, pfeldman wrote: > requestReload? reloadInspectedPage? ...
5 years, 4 months ago (2015-08-14 23:57:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292403004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292403004/20001
5 years, 4 months ago (2015-08-16 17:46:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-16 18:59:08 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-16 18:59:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3030f314d43c2ca51cff507f92911e03067dbecf
Cr-Commit-Position: refs/heads/master@{#343608}

Powered by Google App Engine
This is Rietveld 408576698