Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 12924011: MIPS: Change LookupForWrite to always do a full lookup and check the result. (Closed)

Created:
7 years, 9 months ago by palfia
Modified:
7 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Change LookupForWrite to always do a full lookup and check the result. Port r14061 (df49702a) Original commit message: If we find a property in the prototype-chain that we can overwrite, and we have a transition, keep the holder in the lookup-result as the actual holder. We will need it for the consistency-check in GenerateStoreField. By directly checking the entire chain we avoid having to lazily bail out to a copy of the miss stub while generating the Field Store IC. Currently this CL disallows a normal non-receiver holder, given that that would require a positive lookup + details verification to ensure the property did not become read-only. This fixes the regressions in the attached tests. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M src/mips/stub-cache-mips.cc View 6 chunks +22 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 9 months ago (2013-03-25 16:50:31 UTC) #1
Toon Verwaest
lgtm
7 years, 9 months ago (2013-03-25 17:05:54 UTC) #2
palfia
7 years, 9 months ago (2013-03-25 17:12:59 UTC) #3
Message was sent while issue was closed.
Committed manually as r14070 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698