src/preparser.cc - Issue 1292393002: [parser] make kInvalidLhsInFor a SyntaxError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.cc

Issue 1292393002: [parser] make kInvalidLhsInFor a SyntaxError (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Correct tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.cc

diff --git a/src/preparser.cc b/src/preparser.cc

index 9a30ca58cc71b18031b17ff9cd152e95826a50f1..b1541f616afe133554881e99aec4f71a9f5e45e0 100644

--- a/src/preparser.cc

+++ b/src/preparser.cc

@@ -922,7 +922,7 @@ PreParser::Statement PreParser::ParseForStatement(bool* ok) {

if (!*ok) return Statement::Default();

lhs = CheckAndRewriteReferenceExpression(

lhs, lhs_beg_pos, lhs_end_pos, MessageTemplate::kInvalidLhsInFor,

- CHECK_OK);

+ kSyntaxError, CHECK_OK);

ParseExpression(true, CHECK_OK);

Expect(Token::RPAREN, CHECK_OK);

ParseSubStatement(CHECK_OK);

« no previous file with comments | « src/preparser.h ('k') | test/message/for-loop-invalid-lhs.out » ('j') | no next file with comments »