src/parser.cc - Issue 1292393002: [parser] make kInvalidLhsInFor a SyntaxError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 1292393002: [parser] make kInvalidLhsInFor a SyntaxError (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Correct tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 301bda94c4011987aff1a704a5f2e6f84d79c137..e3e561a31856c1329d998663063e11100ca04db6 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -3693,7 +3693,7 @@ Statement* Parser::ParseForStatement(ZoneList<const AstRawString*>* labels,

if (!*ok) return nullptr;

expression = this->CheckAndRewriteReferenceExpression(

expression, lhs_beg_pos, lhs_end_pos,

- MessageTemplate::kInvalidLhsInFor, CHECK_OK);

+ MessageTemplate::kInvalidLhsInFor, kSyntaxError, CHECK_OK);

ForEachStatement* loop =

factory()->NewForEachStatement(mode, labels, stmt_pos);

« no previous file with comments | « no previous file | src/preparser.h » ('j') | no next file with comments »