Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1292383007: [turbofan] Do not optimize with/block-context allocation in global code. (Closed)

Created:
5 years, 4 months ago by Jarin
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Do not optimize with/block-context allocation in global code. BUG= R=mstarzinger@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : Same for block context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jarin
Could you take a look, please?
5 years, 4 months ago (2015-08-19 14:16:38 UTC) #1
Michael Starzinger
Looking good modulo one comment. https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc#newcode1238 src/compiler/js-typed-lowering.cc:1238: Node* const closure = ...
5 years, 4 months ago (2015-08-19 14:19:24 UTC) #2
Jarin
https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc#newcode1238 src/compiler/js-typed-lowering.cc:1238: Node* const closure = NodeProperties::GetValueInput(node, 1); On 2015/08/19 14:19:24, ...
5 years, 4 months ago (2015-08-20 05:26:01 UTC) #3
Michael Starzinger
5 years, 4 months ago (2015-08-20 07:30:39 UTC) #4
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698