Issue 1292383007: [turbofan] Do not optimize with/block-context allocation in global code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1292383007: [turbofan] Do not optimize with/block-context allocation in global code. (Closed)

Created:
5 years, 4 months ago by Jarin

Modified:
5 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Do not optimize with/block-context allocation in global code. BUG= R=mstarzinger@chromium.org

Patch Set 2 : Same for block context #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	src/compiler/js-typed-lowering.cc	View	1	2 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

Looking good modulo one comment. https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc#newcode1238 src/compiler/js-typed-lowering.cc:1238: Node* const closure = ...

5 years, 4 months ago (2015-08-19 14:19:24 UTC) #2

Jarin

https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc#newcode1238 src/compiler/js-typed-lowering.cc:1238: Node* const closure = NodeProperties::GetValueInput(node, 1); On 2015/08/19 14:19:24, ...

5 years, 4 months ago (2015-08-20 05:26:01 UTC) #3

LGTM. Thanks!

Expand Messages | Collapse Messages

Issue 1292383007: [turbofan] Do not optimize with/block-context allocation in global code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Same for block context #

Messages