Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8594)

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

Issue 1292353006: Mac Changes for BubbleManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mcdb-mac-3.gitbr
Patch Set: New upstream Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h
index bc62cbfcdc266ace04859dc090951f0b602c1af3..a5fe10692acce657c258693e7674555145deed58 100644
--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h
@@ -6,12 +6,13 @@
#include "base/mac/scoped_nsobject.h"
#import "chrome/browser/ui/cocoa/base_bubble_controller.h"
-#include "chrome/browser/ui/website_settings/permission_bubble_view.h"
#include "ui/base/models/simple_menu_model.h"
+class Browser;
@class MenuController;
class PermissionBubbleCocoa;
class PermissionBubbleRequest;
+class PermissionBubbleManager;
@interface PermissionBubbleController :
BaseBubbleController<NSTextViewDelegate> {
@@ -21,7 +22,7 @@ class PermissionBubbleRequest;
base::scoped_nsobject<NSMutableArray> checkboxes_;
// Delegate to be informed of user actions.
- PermissionBubbleView::Delegate* delegate_; // Weak.
+ PermissionBubbleManager* manager_; // Weak.
// Used to determine the correct anchor location and parent window.
Browser* browser_; // Weak.
@@ -38,12 +39,9 @@ class PermissionBubbleRequest;
// Makes the bubble visible. The bubble will be popuplated with text retrieved
// from |requests|. |delegate| will receive callbacks for user actions.
-- (void)showWithDelegate:(PermissionBubbleView::Delegate*)delegate
- forRequests:(const std::vector<PermissionBubbleRequest*>&)requests
- acceptStates:(const std::vector<bool>&)acceptStates;
-
-// Will reposition the bubble based in case the anchor or parent should change.
-- (void)updateAnchorPosition;
+- (void)showWithManager:(PermissionBubbleManager*)manager
+ forRequests:(const std::vector<PermissionBubbleRequest*>&)requests
+ acceptStates:(const std::vector<bool>&)acceptStates;
// Will calculate the expected anchor point for this bubble.
// Should only be used outside this class for tests.

Powered by Google App Engine
This is Rietveld 408576698