Mac Changes for BubbleManager

chrome/browser/ui/cocoa/browser_window_cocoa.mm

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index 00357d6175ce39282020a2bca4d0a262938cc25e..97642d61bd8fee346dc8986a4a6fe039b619c8d3 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -711,7 +711,7 @@ bool BrowserWindowCocoa::PreHandleKeyboardEvent(
   // Handle ESC to dismiss permission bubbles, but still forward it
   // to the window afterwards.
   if (event.windowsKeyCode == ui::VKEY_ESCAPE)

[groby-ooo-7-16, 2015/08/14 18:26:04]

Ugh. That's a big one. I'd rather we don't touch that for a moment. Can you keep
it dismissPermissionBubble and open a thread with egm/aisnlie where we discuss
if we want that for all bubbles? 

(I.e. dismissing the bubble if you press ESC, even if it doesn't have focus)

[hcarmona, 2015/08/18 02:22:21]

Done.

-    [controller_ dismissPermissionBubble];
+    [controller_ dismissBubble];
 
   if (![BrowserWindowUtils shouldHandleKeyboardEvent:event])
     return false;