Mac Changes for BubbleManager

chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"
 
 #include <Carbon/Carbon.h>
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/sdk_forward_declarations.h"
 #include "base/stl_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #import "chrome/browser/ui/cocoa/cocoa_profile_test.h"
 #include "chrome/browser/ui/cocoa/run_loop_testing.h"
 #import "chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h"
 #import "chrome/browser/ui/cocoa/website_settings/split_block_button.h"
 #include "chrome/browser/ui/website_settings/mock_permission_bubble_request.h"
 #include "chrome/grit/generated_resources.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #import "ui/events/test/cocoa_test_event_utils.h"
 
+// TODO(hcarmona): compile this
+
 @class ConstrainedWindowButton;
 
 @interface PermissionBubbleController (ExposedForTesting)
 - (void)ok:(id)sender;
 - (void)onAllow:(id)sender;
 - (void)onBlock:(id)sender;
 - (void)onCustomize:(id)sender;
 - (void)onCheckboxChanged:(id)sender;
 @end
 
@@ skipping 15 matching lines @@
   MOCK_METHOD0(SetCustomizationMode, void());
   MOCK_METHOD0(Accept, void());
   MOCK_METHOD0(Deny, void());
   MOCK_METHOD0(Closing, void());
   MOCK_METHOD1(SetView, void(PermissionBubbleView*));
 
   void SetUp() override {
     CocoaProfileTest::SetUp();
     bridge_.reset(new PermissionBubbleCocoa(browser()));
     AddRequest(kPermissionA);
-    controller_ = [[PermissionBubbleController alloc]
-        initWithParentWindow:test_window()
-                      bridge:bridge_.get()];
+    controller_ =
+        [[PermissionBubbleController alloc] initWithBrowser:browser()
+                                                     bridge:bridge_.get()];
   }
 
   void TearDown() override {
     [controller_ close];
     chrome::testing::NSRunLoopRunAllPending();
     STLDeleteElements(&requests_);
     CocoaProfileTest::TearDown();
   }
 
   void AddRequest(const std::string& title) {
@@ skipping 66 matching lines @@
   std::vector<bool> accept_states_;
 };
 
 TEST_F(PermissionBubbleControllerTest, ShowAndClose) {
   EXPECT_FALSE([[controller_ window] isVisible]);
   [controller_ showWindow:nil];
   EXPECT_TRUE([[controller_ window] isVisible]);
 }
 
 TEST_F(PermissionBubbleControllerTest, ShowSinglePermission) {
-  [controller_ showAtAnchor:NSZeroPoint
-              withDelegate:this
-               forRequests:requests_
-              acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   EXPECT_TRUE(FindTextFieldWithString(kPermissionA));
   EXPECT_TRUE(FindButtonWithTitle(IDS_PERMISSION_ALLOW));
   EXPECT_TRUE(FindButtonWithTitle(IDS_PERMISSION_DENY));
   EXPECT_FALSE(FindButtonWithTitle(IDS_OK));
 }
 
 TEST_F(PermissionBubbleControllerTest, ShowMultiplePermissions) {
   AddRequest(kPermissionB);
   AddRequest(kPermissionC);
 
   accept_states_.push_back(true);  // A
   accept_states_.push_back(true);  // B
   accept_states_.push_back(true);  // C
 
-  [controller_ showAtAnchor:NSZeroPoint
-              withDelegate:this
-               forRequests:requests_
-              acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   EXPECT_TRUE(FindTextFieldWithString(kPermissionA));
   EXPECT_TRUE(FindTextFieldWithString(kPermissionB));
   EXPECT_TRUE(FindTextFieldWithString(kPermissionC));
 
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_ALLOW));
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_DENY));
   EXPECT_TRUE(FindButtonWithTitle(IDS_OK));
 }
 
 TEST_F(PermissionBubbleControllerTest, ShowMultiplePermissionsAllow) {
   AddRequest(kPermissionB);
 
   accept_states_.push_back(true);  // A
   accept_states_.push_back(true);  // B
 
-  [controller_ showAtAnchor:NSZeroPoint
-               withDelegate:this
-                forRequests:requests_
-               acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   // Test that all menus have 'Allow' visible.
   EXPECT_TRUE(FindMenuButtonWithTitle(IDS_PERMISSION_ALLOW));
   EXPECT_FALSE(FindMenuButtonWithTitle(IDS_PERMISSION_DENY));
 
   EXPECT_TRUE(FindButtonWithTitle(IDS_OK));
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_ALLOW));
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_DENY));
 }
 
 TEST_F(PermissionBubbleControllerTest, ShowMultiplePermissionsBlock) {
   AddRequest(kPermissionB);
 
   accept_states_.push_back(false);  // A
   accept_states_.push_back(false);  // B
 
-  [controller_ showAtAnchor:NSZeroPoint
-              withDelegate:this
-               forRequests:requests_
-              acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   // Test that all menus have 'Block' visible.
   EXPECT_TRUE(FindMenuButtonWithTitle(IDS_PERMISSION_DENY));
   EXPECT_FALSE(FindMenuButtonWithTitle(IDS_PERMISSION_ALLOW));
 
   EXPECT_TRUE(FindButtonWithTitle(IDS_OK));
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_ALLOW));
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_DENY));
 }
 
 TEST_F(PermissionBubbleControllerTest, ShowMultiplePermissionsMixed) {
   AddRequest(kPermissionB);
   AddRequest(kPermissionC);
 
   accept_states_.push_back(false);  // A
   accept_states_.push_back(false);  // B
   accept_states_.push_back(true);   // C
 
-  [controller_ showAtAnchor:NSZeroPoint
-              withDelegate:this
-               forRequests:requests_
-              acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   // Test that both 'allow' and 'deny' are visible.
   EXPECT_TRUE(FindMenuButtonWithTitle(IDS_PERMISSION_DENY));
   EXPECT_TRUE(FindMenuButtonWithTitle(IDS_PERMISSION_ALLOW));
 
   EXPECT_TRUE(FindButtonWithTitle(IDS_OK));
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_ALLOW));
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_DENY));
 }
 
 TEST_F(PermissionBubbleControllerTest, OK) {
   AddRequest(kPermissionB);
 
   accept_states_.push_back(true);  // A
   accept_states_.push_back(true);  // B
 
-  [controller_ showAtAnchor:NSZeroPoint
-              withDelegate:this
-               forRequests:requests_
-              acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   EXPECT_CALL(*this, Accept()).Times(1);
   [FindButtonWithTitle(IDS_OK) performClick:nil];
 }
 
 TEST_F(PermissionBubbleControllerTest, Allow) {
-  [controller_ showAtAnchor:NSZeroPoint
-              withDelegate:this
-               forRequests:requests_
-              acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   EXPECT_CALL(*this, Accept()).Times(1);
   [FindButtonWithTitle(IDS_PERMISSION_ALLOW) performClick:nil];
 }
 
 TEST_F(PermissionBubbleControllerTest, Deny) {
-  [controller_ showAtAnchor:NSZeroPoint
-              withDelegate:this
-               forRequests:requests_
-              acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   EXPECT_CALL(*this, Deny()).Times(1);
   [FindButtonWithTitle(IDS_PERMISSION_DENY) performClick:nil];
 }
 
 TEST_F(PermissionBubbleControllerTest, ChangePermissionSelection) {
   AddRequest(kPermissionB);
 
   accept_states_.push_back(true);   // A
   accept_states_.push_back(false);  // B
 
-  [controller_ showAtAnchor:NSZeroPoint
-              withDelegate:this
-               forRequests:requests_
-              acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   EXPECT_CALL(*this, ToggleAccept(0, false)).Times(1);
   EXPECT_CALL(*this, ToggleAccept(1, true)).Times(1);
   NSButton* menu_a = FindMenuButtonWithTitle(IDS_PERMISSION_ALLOW);
   NSButton* menu_b = FindMenuButtonWithTitle(IDS_PERMISSION_DENY);
   ChangePermissionMenuSelection(menu_a, IDS_PERMISSION_DENY);
   ChangePermissionMenuSelection(menu_b, IDS_PERMISSION_ALLOW);
 }
 
 TEST_F(PermissionBubbleControllerTest, EscapeCloses) {
-  [controller_ showAtAnchor:NSZeroPoint
-               withDelegate:this
-                forRequests:requests_
-               acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   EXPECT_TRUE([[controller_ window] isVisible]);
   [[controller_ window]
       performKeyEquivalent:cocoa_test_event_utils::KeyEventWithKeyCode(
                                kVK_Escape, '\e', NSKeyDown, 0)];
   EXPECT_FALSE([[controller_ window] isVisible]);
 }
 
 TEST_F(PermissionBubbleControllerTest, EnterFullscreen) {
-  [controller_ showAtAnchor:NSZeroPoint
-               withDelegate:this
-                forRequests:requests_
-               acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   EXPECT_TRUE([[controller_ window] isVisible]);
 
   // Post the "enter fullscreen" notification.
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   [center postNotificationName:NSWindowWillEnterFullScreenNotification
                         object:test_window()];
 
   EXPECT_TRUE([[controller_ window] isVisible]);
 }
 
 TEST_F(PermissionBubbleControllerTest, ExitFullscreen) {
-  [controller_ showAtAnchor:NSZeroPoint
-               withDelegate:this
-                forRequests:requests_
-               acceptStates:accept_states_];
+  [controller_ showWithDelegate:this
+                    forRequests:requests_
+                   acceptStates:accept_states_];
 
   EXPECT_TRUE([[controller_ window] isVisible]);
 
   // Post the "enter fullscreen" notification.
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   [center postNotificationName:NSWindowWillExitFullScreenNotification
                         object:test_window()];
 
   EXPECT_TRUE([[controller_ window] isVisible]);
 }