Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292333004: Make hit-test support clip-path references using svg clipPath (Closed)

Created:
5 years, 4 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 4 months ago
Reviewers:
pdr., fs, Rick Byers
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make hit-test support clip-path references using svg clipPath BUG=518816 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201078

Patch Set 1 #

Patch Set 2 : add layout test file #

Total comments: 11

Patch Set 3 : using circle clip-path & using elementFromPoint() in layout tests #

Patch Set 4 : layout test rebaseline #

Patch Set 5 : rebaseline for virutal test suites #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/hit-test-clip-path-reference.html View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/hit-test-clip-path-reference-expected.txt View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 24 (12 generated)
Yufeng Shen (Slow to review)
5 years, 4 months ago (2015-08-19 20:53:51 UTC) #2
fs
LGTM w/ some nits and test suggestions https://codereview.chromium.org/1292333004/diff/20001/LayoutTests/fast/events/hit-test-clip-path-reference.html File LayoutTests/fast/events/hit-test-clip-path-reference.html (right): https://codereview.chromium.org/1292333004/diff/20001/LayoutTests/fast/events/hit-test-clip-path-reference.html#newcode16 LayoutTests/fast/events/hit-test-clip-path-reference.html:16: <body> Unnecessary. ...
5 years, 4 months ago (2015-08-19 22:04:57 UTC) #3
pdr.
LGTM 2 https://codereview.chromium.org/1292333004/diff/20001/LayoutTests/fast/events/hit-test-clip-path-reference.html File LayoutTests/fast/events/hit-test-clip-path-reference.html (right): https://codereview.chromium.org/1292333004/diff/20001/LayoutTests/fast/events/hit-test-clip-path-reference.html#newcode19 LayoutTests/fast/events/hit-test-clip-path-reference.html:19: <rect x="0.2" y="0.2" width="0.5" height="0.5"/> On 2015/08/19 ...
5 years, 4 months ago (2015-08-19 22:08:43 UTC) #5
Yufeng Shen (Slow to review)
https://codereview.chromium.org/1292333004/diff/20001/LayoutTests/fast/events/hit-test-clip-path-reference.html File LayoutTests/fast/events/hit-test-clip-path-reference.html (right): https://codereview.chromium.org/1292333004/diff/20001/LayoutTests/fast/events/hit-test-clip-path-reference.html#newcode16 LayoutTests/fast/events/hit-test-clip-path-reference.html:16: <body> On 2015/08/19 22:04:57, fs wrote: > Unnecessary. Done. ...
5 years, 4 months ago (2015-08-20 20:17:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292333004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292333004/40001
5 years, 4 months ago (2015-08-20 21:08:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/101939)
5 years, 4 months ago (2015-08-20 23:03:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292333004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292333004/60001
5 years, 4 months ago (2015-08-24 19:20:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/59956)
5 years, 4 months ago (2015-08-24 20:16:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292333004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292333004/60001
5 years, 4 months ago (2015-08-24 20:19:19 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103304)
5 years, 4 months ago (2015-08-24 20:50:54 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292333004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292333004/80001
5 years, 4 months ago (2015-08-24 21:05:33 UTC) #23
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 23:48:42 UTC) #24
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201078

Powered by Google App Engine
This is Rietveld 408576698