Issue 1292313007: Cherry pick MIPS build fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1292313007: Cherry pick MIPS build fix (Closed)

Created:
5 years, 4 months ago by Johann

Modified:
5 years, 4 months ago

Reviewers:
David Trainor- moved to gerrit

CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan, gordana.cmiljanovic_imgtec.com

Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx@master

Target Ref:
refs/heads/master

Project:
chromium_deps

Visibility:
Public.

More Reviews

Description

Cherry pick MIPS build fix https://chromium-review.googlesource.com/#/c/291080/2 endian_inl.h: fix mips32 android build when configuring with mips32-android-gcc HAVE_MIPS32 would be set, but the ndk does not set -mips32r2 for APP_ABI=mips which results in BSwap32 failing to build; refine the check in endian_inl.h BUG=522435 TBR=dtrainor@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/6503766dba4b3c56e7f0c2f6015f66d7416c1103

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	source/libvpx/vpx_util/endian_inl.h	View		2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johann

Committed patchset #1 (id:1) manually as 6503766dba4b3c56e7f0c2f6015f66d7416c1103 (presubmit successful).

5 years, 4 months ago (2015-08-20 15:44:21 UTC) #1

gordanac

On 2015/08/20 15:44:21, Johann wrote: > Committed patchset #1 (id:1) manually as > 6503766dba4b3c56e7f0c2f6015f66d7416c1103 (presubmit ...

5 years, 4 months ago (2015-08-20 17:29:34 UTC) #2

Johann

5 years, 4 months ago (2015-08-20 17:39:57 UTC) #3

Message was sent while issue was closed.

On 2015/08/20 17:29:34, gordanac wrote:
> On 2015/08/20 15:44:21, Johann wrote:
> > Committed patchset #1 (id:1) manually as
> > 6503766dba4b3c56e7f0c2f6015f66d7416c1103 (presubmit successful).
> 
> Thank you for fixing it, I was preparing the same.

No problem. Please let me know if any other issues pop up.

Expand Messages | Collapse Messages