Update usage of Proguard in clank after moving Proguard to third_party.

Update usage of Proguard in clank after moving Proguard to third_party.

This is a follow up CL of https://codereview.chromium.org/1288393002/.

BUG=505932
Committed: https://crrev.com/fac74610cdba9a4d9190c21a5880b751d3324634
Cr-Commit-Position: refs/heads/master@{#346006}

[Xi Han, 2015-08-24 17:12:59]

hanxi@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Xi Han, 2015-08-24 17:13:00]

Maybe we can ignore the changes in proguard.flags for now, since we might still
need to use Proguard 4.7 due to fact that Proguard 5.1 increases the Chrome.apk
size. Please take a look, thanks.

[Yaron, 2015-08-25 16:57:35]

lgtm after dependent change lands and rebase

You'll need an android build OWNER though

https://codereview.chromium.org/1292313004/diff/20001/build/android/pylib/con...
File build/android/pylib/constants/__init__.py (right):

https://codereview.chromium.org/1292313004/diff/20001/build/android/pylib/con...
build/android/pylib/constants/__init__.py:195: PROGUARD_ROOT =
os.path.join(DIR_SOURCE_ROOT, 'third_party/proguard')
You're going to have to rebase on https://codereview.chromium.org/1278573002/
which is in the CQ

https://codereview.chromium.org/1292313004/diff/20001/chrome/android/java/pro...
File chrome/android/java/proguard.flags (right):

https://codereview.chromium.org/1292313004/diff/20001/chrome/android/java/pro...
chrome/android/java/proguard.flags:34: -assumenosideeffects class
com.google.android.apps.chrome.**,org.chromium.** {
Ya, I think just revert this for now

[Xi Han, 2015-08-25 19:14:55]

hanxi@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Xi Han, 2015-08-25 19:14:56]

jbudorick@chromium.org: Please review all changes, thanks!

https://codereview.chromium.org/1292313004/diff/20001/build/android/pylib/con...
File build/android/pylib/constants/__init__.py (right):

https://codereview.chromium.org/1292313004/diff/20001/build/android/pylib/con...
build/android/pylib/constants/__init__.py:195: PROGUARD_ROOT =
os.path.join(DIR_SOURCE_ROOT, 'third_party/proguard')
On 2015/08/25 16:57:35, Yaron wrote:
> You're going to have to rebase on https://codereview.chromium.org/1278573002/
> which is in the CQ

I keep tracking this CL but it has been reverted, I will rebase once it is
landed.

[jbudorick, 2015-08-27 20:10:26]

lgtm w/ nits

https://codereview.chromium.org/1292313004/diff/40001/build/android/pylib/con...
File build/android/pylib/constants/__init__.py (right):

https://codereview.chromium.org/1292313004/diff/40001/build/android/pylib/con...
build/android/pylib/constants/__init__.py:196: PROGUARD_ROOT =
os.path.join(DIR_SOURCE_ROOT, 'third_party/proguard')
nit: os.path.join(DIR_SOURCE_ROOT, 'third_party', 'proguard')

https://codereview.chromium.org/1292313004/diff/40001/build/android/pylib/ins...
File build/android/pylib/instrumentation/test_jar.py (right):

https://codereview.chromium.org/1292313004/diff/40001/build/android/pylib/ins...
build/android/pylib/instrumentation/test_jar.py:49: 'lib/proguard.jar')
Hm, why are we using 'paths/with/slashes' inside joins...

anyway, same nit as above.

[Xi Han, 2015-08-27 21:54:12]

The CQ bit was checked by hanxi@chromium.org

[Xi Han, 2015-08-27 21:54:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1292313004/#ps60001
(title: "jbudorick@'s")

[commit-bot: I haz the power, 2015-08-27 21:55:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1292313004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1292313004/60001

[commit-bot: I haz the power, 2015-08-27 22:23:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-27 22:23:56]

Patchset 4 (id:??) landed as
https://crrev.com/fac74610cdba9a4d9190c21a5880b751d3324634
Cr-Commit-Position: refs/heads/master@{#346006}