Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1292303005: Make core/editing/ files to match Blink coding style (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent, Nico
CC:
blink-reviews, groby+blinkspell_chromium.org, blink-reviews-style_chromium.org, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make core/editing/ files to match Blink coding style This patch makes files in "core/editing/" to match Blink coding style and formatting comments, near style changes, to fit 80 characters to ease of working these files in the future for improving code health. Note: Naming related style violation will be addressed in other patches to reduce size of patches. This patch is also a preparation of moving execCommand related files, http://crrev.com/1294543005 BUG=509257 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200687

Patch Set 1 : 2015-08-18T10:48:50 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -177 lines) Patch
M Source/core/editing/ApplyBlockElementCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 6 chunks +17 lines, -14 lines 0 comments Download
M Source/core/editing/CreateLinkCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 9 chunks +29 lines, -23 lines 0 comments Download
M Source/core/editing/EditAction.h View 1 chunk +43 lines, -43 lines 0 comments Download
M Source/core/editing/EditingStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 3 chunks +21 lines, -20 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/FrameSelection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 5 chunks +15 lines, -9 lines 0 comments Download
M Source/core/editing/InputMethodController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 2 chunks +9 lines, -6 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 3 chunks +13 lines, -12 lines 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 9 chunks +28 lines, -21 lines 0 comments Download
M Source/core/editing/SetNodeAttributeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SmartReplaceCF.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/SmartReplaceICU.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/TextAffinity.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/editing/VisibleSelection.h View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-18 02:11:12 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-18 02:25:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292303005/1
5 years, 4 months ago (2015-08-18 02:26:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200687
5 years, 4 months ago (2015-08-18 04:23:03 UTC) #6
Nico
5 years, 4 months ago (2015-08-18 04:50:34 UTC) #8
Message was sent while issue was closed.
wrong bug #

Powered by Google App Engine
This is Rietveld 408576698