src/v8natives.js - Issue 1292283004: Do not use js builtins object to determine whether a function is a builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 1292283004: Do not use js builtins object to determine whether a function is a builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove redundant check Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8natives.js

diff --git a/src/v8natives.js b/src/v8natives.js

index 93636d008f1b6639a79f885812549e415e24d164..dc1d34cfbcb84939fc147f2fe0cd31314188935f 100644

--- a/src/v8natives.js

+++ b/src/v8natives.js

@@ -1622,7 +1622,7 @@ function FunctionSourceString(func) {

throw MakeTypeError(kNotGeneric, 'Function.prototype.toString');

}

- if (%FunctionIsBuiltin(func)) {

+ if (%FunctionHidesSource(func)) {

return NativeCodeFunctionSourceString(func);

}

« no previous file with comments | « src/runtime/runtime-function.cc ('k') | no next file » | no next file with comments »