src/runtime/runtime.h - Issue 1292283004: Do not use js builtins object to determine whether a function is a builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime.h

Issue 1292283004: Do not use js builtins object to determine whether a function is a builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove redundant check Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime.h

diff --git a/src/runtime/runtime.h b/src/runtime/runtime.h

index 7107bdef372134c863d35c1c3b642fba02033d89..4048cfb9bbbd02bc169bcbd143be1187972b9eb3 100644

--- a/src/runtime/runtime.h

+++ b/src/runtime/runtime.h

@@ -236,7 +236,7 @@ namespace internal {

F(FunctionSetLength, 2, 1) \

F(FunctionSetPrototype, 2, 1) \

F(FunctionIsAPIFunction, 1, 1) \

- F(FunctionIsBuiltin, 1, 1) \

+ F(FunctionHidesSource, 1, 1) \

F(SetCode, 2, 1) \

F(SetNativeFlag, 1, 1) \

F(ThrowStrongModeTooFewArguments, 0, 1) \

« no previous file with comments | « src/objects-inl.h ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »