src/debug/debug-scopes.cc - Issue 1292283004: Do not use js builtins object to determine whether a function is a builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-scopes.cc

Issue 1292283004: Do not use js builtins object to determine whether a function is a builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove redundant check Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/debug-scopes.cc

diff --git a/src/debug/debug-scopes.cc b/src/debug/debug-scopes.cc

index b9204f60500c71cea9dd687ddd2f7cffce62d29c..4703e9c3c450ad047f4c1b4e73de6fa53270b69b 100644

--- a/src/debug/debug-scopes.cc

+++ b/src/debug/debug-scopes.cc

@@ -118,7 +118,7 @@ ScopeIterator::ScopeIterator(Isolate* isolate, Handle<JSFunction> function)

context_(function->context()),

seen_script_scope_(false),

failed_(false) {

- if (function->IsBuiltin()) context_ = Handle<Context>();

+ if (!function->IsSubjectToDebugging()) context_ = Handle<Context>();

}

« no previous file with comments | « src/debug/debug.cc ('k') | src/isolate.cc » ('j') | no next file with comments »