Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: src/debug/debug.cc

Issue 1292283004: Do not use js builtins object to determine whether a function is a builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove redundant check Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2259 matching lines...) Expand 10 before | Expand all | Expand 10 after
2270 if (!is_active()) return; 2270 if (!is_active()) return;
2271 2271
2272 StackLimitCheck check(isolate_); 2272 StackLimitCheck check(isolate_);
2273 if (check.HasOverflowed()) return; 2273 if (check.HasOverflowed()) return;
2274 2274
2275 { JavaScriptFrameIterator it(isolate_); 2275 { JavaScriptFrameIterator it(isolate_);
2276 DCHECK(!it.done()); 2276 DCHECK(!it.done());
2277 Object* fun = it.frame()->function(); 2277 Object* fun = it.frame()->function();
2278 if (fun && fun->IsJSFunction()) { 2278 if (fun && fun->IsJSFunction()) {
2279 // Don't stop in builtin functions. 2279 // Don't stop in builtin functions.
2280 if (JSFunction::cast(fun)->IsBuiltin()) return; 2280 if (!JSFunction::cast(fun)->IsSubjectToDebugging()) return;
2281 GlobalObject* global = JSFunction::cast(fun)->context()->global_object(); 2281 GlobalObject* global = JSFunction::cast(fun)->context()->global_object();
2282 // Don't stop in debugger functions. 2282 // Don't stop in debugger functions.
2283 if (IsDebugGlobal(global)) return; 2283 if (IsDebugGlobal(global)) return;
2284 } 2284 }
2285 } 2285 }
2286 2286
2287 // Collect the break state before clearing the flags. 2287 // Collect the break state before clearing the flags.
2288 bool debug_command_only = isolate_->stack_guard()->CheckDebugCommand() && 2288 bool debug_command_only = isolate_->stack_guard()->CheckDebugCommand() &&
2289 !isolate_->stack_guard()->CheckDebugBreak(); 2289 !isolate_->stack_guard()->CheckDebugBreak();
2290 2290
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
2613 } 2613 }
2614 2614
2615 2615
2616 void LockingCommandMessageQueue::Clear() { 2616 void LockingCommandMessageQueue::Clear() {
2617 base::LockGuard<base::Mutex> lock_guard(&mutex_); 2617 base::LockGuard<base::Mutex> lock_guard(&mutex_);
2618 queue_.Clear(); 2618 queue_.Clear();
2619 } 2619 }
2620 2620
2621 } // namespace internal 2621 } // namespace internal
2622 } // namespace v8 2622 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698