Issue 1292283002: Merge to XFA: Tidy up JS_Object.h and JS_Object.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1292283002: Merge to XFA: Tidy up JS_Object.h and JS_Object.cpp. (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Tidy up JS_Object.h and JS_Object.cpp. (cherry picked from commit b0b1a8bd45ed72e4fd22f5f0a394b7897ae573c7) Original Review URL: https://codereview.chromium.org/1293673003 . TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/371c87f65f2545ac329ca2f8db9c1f964babf1aa

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -74 lines)			Patch
	M	fpdfsdk/include/javascript/JS_Object.h	View		4 chunks	+22 lines, -60 lines	0 comments	Download
	M	fpdfsdk/src/javascript/JS_Object.cpp	View		5 chunks	+40 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as 371c87f65f2545ac329ca2f8db9c1f964babf1aa (presubmit successful).

5 years, 4 months ago (2015-08-13 23:56:22 UTC) #2

Message was sent while issue was closed.

lgtm