Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: device/bluetooth/bluetooth_device_android.cc

Issue 1292263002: bluetooth: Create base class BluetoothDevice::CreateGattConnection impl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-adapter-
Patch Set: Updated patchset dependency Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_device_android.cc
diff --git a/device/bluetooth/bluetooth_device_android.cc b/device/bluetooth/bluetooth_device_android.cc
index fb0ea7f06fdb4789d8cb31b41ddbaefc316f09d5..6dac465163bc8c2f4e47def44be3abd22ed536b0 100644
--- a/device/bluetooth/bluetooth_device_android.cc
+++ b/device/bluetooth/bluetooth_device_android.cc
@@ -76,8 +76,11 @@ bool BluetoothDeviceAndroid::IsPaired() const {
}
bool BluetoothDeviceAndroid::IsConnected() const {
- NOTIMPLEMENTED();
- return false;
+ return IsGattConnected();
+}
+
+bool BluetoothDeviceAndroid::IsGattConnected() const {
+ return gatt_connected_;
}
bool BluetoothDeviceAndroid::IsConnectable() const {
@@ -185,10 +188,6 @@ void BluetoothDeviceAndroid::ConnectToServiceInsecurely(
NOTIMPLEMENTED();
}
-void BluetoothDeviceAndroid::CreateGattConnection(
- const GattConnectionCallback& callback,
- const ConnectErrorCallback& error_callback) {
- NOTIMPLEMENTED();
}
BluetoothDeviceAndroid::BluetoothDeviceAndroid(BluetoothAdapterAndroid* adapter)
@@ -199,4 +198,15 @@ std::string BluetoothDeviceAndroid::GetDeviceName() const {
AttachCurrentThread(), j_device_.obj()));
}
+void BluetoothDeviceAndroid::CreateGattConnectionImpl() {
+ // Implemented in following patch https://codereview.chromium.org/1256313002
+ NOTIMPLEMENTED();
+ DidFailToConnectGatt(ERROR_UNKNOWN);
+}
+
+void BluetoothDeviceAndroid::DisconnectGatt() {
+ // Implemented in following patch https://codereview.chromium.org/1256313002
+ NOTIMPLEMENTED();
+}
+
} // namespace device

Powered by Google App Engine
This is Rietveld 408576698