Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 1292233004: [turbofan] Gracefully handle missing info()->context() in CodeGenerator::IsMaterializableFromFrame() (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Gracefully handle missing info()->context() in CodeGenerator::IsMaterializableFromFrame() R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/a38a573ade0b306a961b32be8065fb0db9898cee Cr-Commit-Position: refs/heads/master@{#30176}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/compiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
titzer
5 years, 4 months ago (2015-08-14 11:31:08 UTC) #1
Michael Starzinger
https://codereview.chromium.org/1292233004/diff/1/src/compiler/code-generator.cc File src/compiler/code-generator.cc (right): https://codereview.chromium.org/1292233004/diff/1/src/compiler/code-generator.cc#newcode535 src/compiler/code-generator.cc:535: if (!info()->parse_info()) return; // TODO(titzer): that was unfortunate. nit: ...
5 years, 4 months ago (2015-08-14 11:52:38 UTC) #2
titzer
On 2015/08/14 11:52:38, Michael Starzinger wrote: > https://codereview.chromium.org/1292233004/diff/1/src/compiler/code-generator.cc > File src/compiler/code-generator.cc (right): > > https://codereview.chromium.org/1292233004/diff/1/src/compiler/code-generator.cc#newcode535 ...
5 years, 4 months ago (2015-08-14 12:32:23 UTC) #3
Michael Starzinger
LGTM if Jaro concurs.
5 years, 4 months ago (2015-08-14 12:35:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292233004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292233004/20001
5 years, 4 months ago (2015-08-14 12:42:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 13:07:34 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 13:07:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a38a573ade0b306a961b32be8065fb0db9898cee
Cr-Commit-Position: refs/heads/master@{#30176}

Powered by Google App Engine
This is Rietveld 408576698