Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: Source/core/paint/DeprecatedPaintLayerFilterInfo.cpp

Issue 1292213004: DeprecatedPaintLayerFilterInfo::notifyFinished should use filterNeedsPaintInvalidation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/DeprecatedPaintLayerFilterInfo.cpp
diff --git a/Source/core/paint/DeprecatedPaintLayerFilterInfo.cpp b/Source/core/paint/DeprecatedPaintLayerFilterInfo.cpp
index 22482a2467fad1bac95a2acf2780b814c17c857c..a83ffb297faa070ccc7642dccf002e39d9dd0674 100644
--- a/Source/core/paint/DeprecatedPaintLayerFilterInfo.cpp
+++ b/Source/core/paint/DeprecatedPaintLayerFilterInfo.cpp
@@ -100,13 +100,7 @@ void DeprecatedPaintLayerFilterInfo::setBuilder(PassRefPtrWillBeRawPtr<FilterEff
void DeprecatedPaintLayerFilterInfo::notifyFinished(Resource*)
{
- LayoutObject* layoutObject = m_layer->layoutObject();
- // FIXME: This caller of scheduleSVGFilterLayerUpdateHack() is not correct. It's using the layer update
- // system to trigger a Layer to go through the filter updating logic, but that might not
- // even happen if this element is style sharing and LayoutObject::setStyle() returns early.
- // Filters need to find a better way to hook into the system.
- toElement(layoutObject->node())->scheduleSVGFilterLayerUpdateHack();
- layoutObject->setShouldDoFullPaintInvalidation();
+ m_layer->filterNeedsPaintInvalidation();
}
void DeprecatedPaintLayerFilterInfo::updateReferenceFilterClients(const FilterOperations& operations)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698