Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1292143004: Perform deep copy of NavigationItems for serialization. (Closed)

Created:
5 years, 4 months ago by kkhorimoto
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Perform deep copy of NavigationItems for serialization. This fixes the race condition in which NavigationItems that were constructed on the main thread are being deallocated on the IO thread during session serialization. BUG=none Committed: https://crrev.com/73915e9ce18847fb5ab8672ed01b0af2057f8890 Cr-Commit-Position: refs/heads/master@{#344059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/web/navigation/crw_session_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
kkhorimoto
This prevents hitting the thread checker DCHECK when NavigationItems are deallocated on the IO thread.
5 years, 4 months ago (2015-08-18 21:06:57 UTC) #2
Eugene But (OOO till 7-30)
lgtm, thanks for fixing this
5 years, 4 months ago (2015-08-18 21:26:25 UTC) #3
bhnascar
On 2015/08/18 21:26:25, eugenebut wrote: > lgtm, thanks for fixing this LGTM, thanks!
5 years, 4 months ago (2015-08-18 21:29:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292143004/1
5 years, 4 months ago (2015-08-18 21:34:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 22:48:32 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 22:49:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73915e9ce18847fb5ab8672ed01b0af2057f8890
Cr-Commit-Position: refs/heads/master@{#344059}

Powered by Google App Engine
This is Rietveld 408576698