Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1292053006: Revert of [Android] Add --blacklist-file as a command-line option. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, telemetry-reviews_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add --blacklist-file as a command-line option. (patchset #5 id:80001 of https://codereview.chromium.org/1281923003/ ) Reason for revert: broke the perf bots, will fix and reland. Original issue's description: > [Android] Add --blacklist-file as a command-line option. > > BUG=517709 > > Committed: https://crrev.com/9874769cf24b5870d9bb7c22fe5312b1cf8bcd5e > Cr-Commit-Position: refs/heads/master@{#344125} TBR=eakuefner@chromium.org,mikecase@chromium.org,nednguyen@google.com,rnephew@chromium.org,sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517709 Committed: https://crrev.com/0dfa60a346d99e7a9420496a585dfc5ec36f0fe7 Cr-Commit-Position: refs/heads/master@{#344141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -308 lines) Patch
M build/android/adb_install_apk.py View 3 chunks +5 lines, -14 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 3 chunks +1 line, -8 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 11 chunks +41 lines, -47 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/enable_asserts.py View 2 chunks +1 line, -10 lines 0 comments Download
M build/android/host_heartbeat.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/provision_devices.py View 3 chunks +15 lines, -22 lines 0 comments Download
M build/android/pylib/device/device_blacklist.py View 1 chunk +36 lines, -57 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 3 chunks +7 lines, -9 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 3 chunks +26 lines, -8 lines 0 comments Download
M build/android/pylib/host_driven/test_case.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/instrumentation/setup.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 3 chunks +2 lines, -3 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 3 chunks +1 line, -5 lines 0 comments Download
M build/android/pylib/perf/perf_control_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/perf/setup.py View 4 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/uiautomator/setup.py View 2 chunks +2 lines, -4 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 3 chunks +6 lines, -8 lines 0 comments Download
M build/android/pylib/utils/test_environment.py View 2 chunks +3 lines, -7 lines 0 comments Download
M build/android/screenshot.py View 3 chunks +1 line, -8 lines 0 comments Download
M build/android/test_runner.py View 9 chunks +7 lines, -17 lines 0 comments Download
M build/android/tombstones.py View 3 chunks +1 line, -8 lines 0 comments Download
M build/android/update_verification.py View 3 chunks +1 line, -8 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_runner.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/browser/browser_options.py View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/forwarders/android_forwarder.py View 1 chunk +9 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/android_device.py View 6 chunks +14 lines, -27 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/android_device_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/cros_device.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/desktop_device.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/device.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/ios_device.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/trybot_device.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android] Add --blacklist-file as a command-line option.
5 years, 4 months ago (2015-08-19 04:19:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292053006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292053006/1
5 years, 4 months ago (2015-08-19 04:19:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 04:21:10 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 04:21:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dfa60a346d99e7a9420496a585dfc5ec36f0fe7
Cr-Commit-Position: refs/heads/master@{#344141}

Powered by Google App Engine
This is Rietveld 408576698