Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1292053003: Lots of documentation cleanup (Closed)

Created:
5 years, 4 months ago by Dirk Pranke
Modified:
5 years, 4 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp@md-pages
Target Ref:
refs/heads/md-pages
Project:
gyp
Visibility:
Public.

Description

Lots of documentation cleanup - fix the new navbar and page titles - update the "hacking" page, remove the obsolete "buildbot" and "source" pages - remove TODOs and old project info from the "language specification" page R=scottmg@chromium.org BUG=481696 Committed: https://chromium.googlesource.com/external/gyp/+/a69455b4a08ad8ec16ba0b249f2d3c0a1237dfc9

Patch Set 1 #

Patch Set 2 : fix a couple page titles #

Patch Set 3 : update w/ note about "fetch gyp" #

Total comments: 2

Patch Set 4 : more nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -113 lines) Patch
D docs/Buildbot.md View 1 chunk +0 lines, -9 lines 0 comments Download
M docs/GypVsCMake.md View 1 2 chunks +3 lines, -5 lines 0 comments Download
M docs/Hacking.md View 1 2 3 4 chunks +32 lines, -10 lines 0 comments Download
M docs/LanguageSpecification.md View 3 chunks +2 lines, -52 lines 0 comments Download
D docs/Source.md View 1 chunk +0 lines, -3 lines 0 comments Download
M docs/Testing.md View 1 chunk +1 line, -10 lines 0 comments Download
M docs/UserDocumentation.md View 3 chunks +7 lines, -15 lines 0 comments Download
M index.md View 2 chunks +6 lines, -4 lines 0 comments Download
M navbar.md View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
This is a bit more substantive. In addition to fixing the nav bar, I remove ...
5 years, 4 months ago (2015-08-13 22:50:05 UTC) #1
scottmg
lgtm https://codereview.chromium.org/1292053003/diff/40001/docs/GypVsCMake.md File docs/GypVsCMake.md (right): https://codereview.chromium.org/1292053003/diff/40001/docs/GypVsCMake.md#newcode32 docs/GypVsCMake.md:32: substantial period of time, we had a hybrid ...
5 years, 4 months ago (2015-08-13 23:06:41 UTC) #2
Dirk Pranke
Committed patchset #3 (id:40001) manually as a69455b4a08ad8ec16ba0b249f2d3c0a1237dfc9 (presubmit successful).
5 years, 4 months ago (2015-08-13 23:27:04 UTC) #3
Dirk Pranke
5 years, 4 months ago (2015-08-13 23:29:47 UTC) #4
patchset #4 is actually what got committed.

Powered by Google App Engine
This is Rietveld 408576698