Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1292053002: Rework startup-data-util. (Closed)

Created:
5 years, 4 months ago by vogelheim
Modified:
5 years, 4 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rework startup-data-util. - Make the API look like v8::V8::InitializeICU. (That is: A static method call, not an object to be created on the stack.) - Fix path separator on Windows, by calling base::OS::isPathSeparator. - Move into API, so that it can be called by hello-world & friends. - Actually call it from hello-world and friends. R=jochen@chromium.org BUG= Committed: https://crrev.com/c69e2eae548d4a68bb1b91032e9825709155a8c5 Cr-Commit-Position: refs/heads/master@{#30174}

Patch Set 1 #

Patch Set 2 : Test for all platforms. (This version should not be committed.) #

Patch Set 3 : Rebase and fix silly copy-paste mistake, that was source of the test breakage. #

Patch Set 4 : Same as Patch Set 3, but revert the "Test for all platforms" bits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -112 lines) Patch
M BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M include/v8.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M samples/hello-world.cc View 1 chunk +1 line, -0 lines 0 comments Download
M samples/process.cc View 1 chunk +1 line, -0 lines 0 comments Download
M samples/shell.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M src/d8.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/startup-data-util.h View 1 chunk +9 lines, -31 lines 0 comments Download
M src/startup-data-util.cc View 1 2 2 chunks +68 lines, -42 lines 0 comments Download
M test/cctest/cctest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M test/unittests/run-all-unittests.cc View 2 chunks +1 line, -7 lines 0 comments Download
M test/unittests/unittests.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tools/parser-shell.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M tools/parser-shell.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
vogelheim
Please have a look. - Breakage on v8_linux64_avx2_rel looks unrelated. - The 2nd patch set ...
5 years, 4 months ago (2015-08-13 15:20:37 UTC) #2
jochen (gone - plz use gerrit)
lgtm so far
5 years, 4 months ago (2015-08-13 15:21:52 UTC) #4
vogelheim
On 2015/08/13 15:21:52, jochen (ooo) wrote: > lgtm so far Will commit. The rebase + ...
5 years, 4 months ago (2015-08-14 11:49:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292053002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292053002/100001
5 years, 4 months ago (2015-08-14 11:49:30 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 4 months ago (2015-08-14 12:11:36 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 12:11:55 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c69e2eae548d4a68bb1b91032e9825709155a8c5
Cr-Commit-Position: refs/heads/master@{#30174}

Powered by Google App Engine
This is Rietveld 408576698