Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1292023002: Revert of Debugger: use a Map to cache mirrors. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Yang, yurys
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Debugger: use a Map to cache mirrors. (patchset #1 id:1 of https://codereview.chromium.org/1287243002/ ) Reason for revert: Several nosnap and custom snapshot failures. Original issue's description: > Debugger: use a Map to cache mirrors. > > This makes mirror cache lookup O(1) instead of O(n). > The downside is that the lookup via handle is O(n). This > is fine because handles are only used in the JSON api, > which is not used by Chrome and on death row. > > Committed: https://crrev.com/890b1dfca84d9dfecdcfc56517ef541076c6eb1d > Cr-Commit-Position: refs/heads/master@{#30150} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1f2c5052ce859d20ea75af1da270e18d6ecacc39 Cr-Commit-Position: refs/heads/master@{#30153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M src/bootstrapper.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M src/debug/mirrors.js View 6 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Debugger: use a Map to cache mirrors.
5 years, 4 months ago (2015-08-13 12:09:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292023002/1
5 years, 4 months ago (2015-08-13 12:09:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 12:09:36 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 12:09:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f2c5052ce859d20ea75af1da270e18d6ecacc39
Cr-Commit-Position: refs/heads/master@{#30153}

Powered by Google App Engine
This is Rietveld 408576698