Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1292003007: Update assertion in LayoutBox::intrinsicScrollbarLogicalWidth. (Closed)

Created:
5 years, 4 months ago by skobes
Modified:
5 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, MuVen
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Tolerate nonexistent scrollbar in LayoutBox::intrinsicScrollbarLogicalWidth. DeprecatedPaintLayerScrollableArea will not create an overlay scrollbar if there is no overflow on that axis, even if overflow:scroll is specified. This is intentional behavior added in http://crbug.com/415031. It's correct for intrinsicScrollbarLogicalWidth to return 0 in this case, as it already does for all overlay scrollbars. BUG=520662 TEST=WebViewTest.GeolocationAPIEmbedderHasAccessAllow passes on Mac Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/core/layout/LayoutBox.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
skobes
5 years, 4 months ago (2015-08-20 01:43:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292003007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292003007/1
5 years, 4 months ago (2015-08-20 01:43:57 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22087)
5 years, 4 months ago (2015-08-20 02:11:33 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292003007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292003007/1
5 years, 4 months ago (2015-08-20 02:32:52 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/22048)
5 years, 4 months ago (2015-08-20 03:08:10 UTC) #10
eae
LGTM
5 years, 4 months ago (2015-08-20 17:05:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292003007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292003007/1
5 years, 4 months ago (2015-08-20 17:05:25 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 17:32:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200911

Powered by Google App Engine
This is Rietveld 408576698