Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4189)

Unified Diff: chrome/browser/notifications/notification.h

Issue 1292003004: Elide origins displayed on web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Style nit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification.h
diff --git a/chrome/browser/notifications/notification.h b/chrome/browser/notifications/notification.h
index f8f7690be8d508f8d09e841d715f1b26247e137d..d07ef76f9c46d93d8e585b96fd68f1746505ba9b 100644
--- a/chrome/browser/notifications/notification.h
+++ b/chrome/browser/notifications/notification.h
@@ -33,12 +33,12 @@ class Notification : public message_center::Notification {
Notification(
message_center::NotificationType type,
- const GURL& origin_url,
const base::string16& title,
const base::string16& body,
const gfx::Image& icon,
const message_center::NotifierId& notifier_id,
const base::string16& display_source,
+ const GURL& origin_url,
const std::string& tag,
const message_center::RichNotificationData& rich_notification_data,
NotificationDelegate* delegate);
@@ -49,9 +49,6 @@ class Notification : public message_center::Notification {
~Notification() override;
Notification& operator=(const Notification& notification);
- // The origin URL of the script which requested the notification.
- const GURL& origin_url() const { return origin_url_; }
-
// A unique identifier used to update (replace) or remove a notification.
const std::string& tag() const { return tag_; }
@@ -61,9 +58,6 @@ class Notification : public message_center::Notification {
NotificationDelegate* delegate() const { return delegate_.get(); }
private:
- // The Origin of the page/worker which created this notification.
- GURL origin_url_;
-
// The user-supplied tag for the notification.
std::string tag_;
« no previous file with comments | « chrome/browser/notifications/message_center_notifications_browsertest.cc ('k') | chrome/browser/notifications/notification.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698