Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: trunk/src/ppapi/proxy/ppapi_proxy_test.cc

Issue 12920003: Revert 189518 "PPAPI: Remove threading options; it's always on" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ppapi/proxy/plugin_var_tracker.cc ('k') | trunk/src/ppapi/proxy/ppb_var_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ppapi/proxy/ppapi_proxy_test.cc
===================================================================
--- trunk/src/ppapi/proxy/ppapi_proxy_test.cc (revision 189681)
+++ trunk/src/ppapi/proxy/ppapi_proxy_test.cc (working copy)
@@ -171,8 +171,6 @@
void PluginProxyTestHarness::SetUpHarness() {
// These must be first since the dispatcher set-up uses them.
CreatePluginGlobals();
- // Some of the methods called during set-up check that the lock is held.
- ProxyAutoLock lock;
resource_tracker().DidCreateInstance(pp_instance());
@@ -198,8 +196,6 @@
bool is_client) {
// These must be first since the dispatcher set-up uses them.
CreatePluginGlobals();
- // Some of the methods called during set-up check that the lock is held.
- ProxyAutoLock lock;
resource_tracker().DidCreateInstance(pp_instance());
plugin_delegate_mock_.Init(ipc_message_loop, shutdown_event);
@@ -218,15 +214,10 @@
}
void PluginProxyTestHarness::TearDownHarness() {
- {
- // Some of the methods called during tear-down check that the lock is held.
- ProxyAutoLock lock;
+ plugin_dispatcher_->DidDestroyInstance(pp_instance());
+ plugin_dispatcher_.reset();
- plugin_dispatcher_->DidDestroyInstance(pp_instance());
- plugin_dispatcher_.reset();
-
- resource_tracker().DidDeleteInstance(pp_instance());
- }
+ resource_tracker().DidDeleteInstance(pp_instance());
plugin_globals_.reset();
}
« no previous file with comments | « trunk/src/ppapi/proxy/plugin_var_tracker.cc ('k') | trunk/src/ppapi/proxy/ppb_var_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698